Skip to content

8380223: Refactor test/jdk/sun/util/resources TestNG tests to JUnit - #756

Open
gnu-andrew wants to merge 1 commit into
openjdk:masterfrom
gnu-andrew:JDK-8380223-25u
Open

8380223: Refactor test/jdk/sun/util/resources TestNG tests to JUnit#756
gnu-andrew wants to merge 1 commit into
openjdk:masterfrom
gnu-andrew:JDK-8380223-25u

Conversation

@gnu-andrew

@gnu-andrew gnu-andrew commented Aug 25, 2026

Copy link
Copy Markdown
Member

This backport updates the sun.util.resources tests to use JUnit. It eases the backporting of JDK-8381379: "Support std/dstOffset attributes in CLDR's metazone definitions" - itself a pre-requisite for the next tzdata update - which adds further tests in JUnit format to TimeZoneNamesTest.java. Other changes from the umbrella task (JDK-8307843) for these conversions are already in 25u such as JDK-8310049.

The backport was mostly clean, bar test/jdk/sun/util/resources/TimeZone/Bug8139107.java, which was altered by JDK-8260555: "Change the default TIMEOUT_FACTOR from 4 to 1". I applied the copyright header change and testng -> junit substitution manually, without the timeout in the latter from 8260555.

All tests pass:

$ make -C $HOME/builder/25u-dev run-test TEST="jdk/sun/util/resources"
...
==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR  SKIP   
   jtreg:test/jdk/sun/util/resources                    22    22     0     0     0   
==============================
TEST SUCCESS


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8380223 needs maintainer approval

Issue

  • JDK-8380223: Refactor test/jdk/sun/util/resources TestNG tests to JUnit (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/756/head:pull/756
$ git checkout pull/756

Update a local copy of the PR:
$ git checkout pull/756
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 756

View PR using the GUI difftool:
$ git pr show -t 756

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/756.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 25, 2026

Copy link
Copy Markdown

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 25, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 9ea893d87749fd87a3d1947e6d71c5899c6380bb 8380223: Refactor test/jdk/sun/util/resources TestNG tests to JUnit Aug 25, 2026
@openjdk

openjdk Bot commented Aug 25, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 25, 2026
@mlbridge

mlbridge Bot commented Aug 25, 2026

Copy link
Copy Markdown

Webrevs

@gnu-andrew

gnu-andrew commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Windows failure in java/lang/ScopedValue/StressStackOverflow#default seems unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant