Repository navigation
fix(browser): recheck eligibility before reconnecting - #149
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
marked this pull request as ready for review
November 3, 2026 12:47
vincentkoc
force-pushed
the
fix/libterminal-output-ack-chunks-20261103
branch
from
November 3, 2026 12:49
cf8f1ee to
65394f8
Compare
vincentkoc
force-pushed
the
fix/libterminal-reconnect-eligibility-20261103
branch
2 times, most recently
from
November 3, 2026 12:51
e1bd679 to
7fa55ee
Compare
vincentkoc
force-pushed
the
fix/libterminal-output-ack-chunks-20261103
branch
2 times, most recently
from
November 3, 2026 12:54
6e29409 to
26d6468
Compare
vincentkoc
force-pushed
the
fix/libterminal-reconnect-eligibility-20261103
branch
from
November 3, 2026 12:54
7fa55ee to
01a8f8e
Compare
Base automatically changed from
fix/libterminal-output-ack-chunks-20261103
to
main
November 3, 2026 12:56
vincentkoc
force-pushed
the
fix/libterminal-reconnect-eligibility-20261103
branch
from
November 3, 2026 12:56
01a8f8e to
ad9e242
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconnect eligibility was checked when a timer was scheduled but ignored when it fired. Recheck the application predicate after the delay and respect a close triggered by that predicate. Tests cover lost demand, a throwing predicate, and a reentrant close. Production delta: +3 lines; no new options or defaults.
Validation
ad9e24290af3f38c59d3d1cfbb6aee15f57be510.4962e77d5c98f1cb8fd2314849951c590005e9b2. Rebased code and test patches were verified unchanged.