Repository navigation
fix: preserve explicit null terminal abort reasons - #150
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
marked this pull request as ready for review
November 3, 2026 12:47
vincentkoc
force-pushed
the
fix/libterminal-null-abort-reasons-20261103
branch
from
November 3, 2026 12:49
bca86e9 to
c7f095d
Compare
vincentkoc
force-pushed
the
fix/libterminal-reconnect-eligibility-20261103
branch
2 times, most recently
from
November 3, 2026 12:51
e1bd679 to
7fa55ee
Compare
vincentkoc
force-pushed
the
fix/libterminal-null-abort-reasons-20261103
branch
2 times, most recently
from
November 3, 2026 12:54
61e8bd4 to
db5b5fd
Compare
vincentkoc
force-pushed
the
fix/libterminal-reconnect-eligibility-20261103
branch
from
November 3, 2026 12:54
7fa55ee to
01a8f8e
Compare
vincentkoc
force-pushed
the
fix/libterminal-null-abort-reasons-20261103
branch
from
November 3, 2026 12:56
db5b5fd to
a5a7dea
Compare
vincentkoc
force-pushed
the
fix/libterminal-reconnect-eligibility-20261103
branch
from
November 3, 2026 12:56
01a8f8e to
ad9e242
Compare
Base automatically changed from
fix/libterminal-reconnect-eligibility-20261103
to
main
November 3, 2026 12:58
vincentkoc
force-pushed
the
fix/libterminal-null-abort-reasons-20261103
branch
from
November 3, 2026 12:59
a5a7dea to
b02b7ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explicit AbortController.abort(null) reasons were replaced by synthesized errors during browser terminal startup and Node PTY creation. Throw the signal reason directly, matching the native AbortSignal contract. Tests verify browser disposal and that an already-aborted Node operation never spawns. Production delta: zero lines; no new API.
Validation
b02b7ecb1aeea3c38688ffe51aef84c1d172ddb1.bca86e9012735506e0887146152a784738eda9a8. Rebased code and test patches were verified unchanged.