Repository navigation
fix(worker): split output acknowledgements at decoder limit - #148
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
marked this pull request as ready for review
November 3, 2026 12:47
vincentkoc
force-pushed
the
fix/libterminal-output-ack-chunks-20261103
branch
from
November 3, 2026 12:49
cf8f1ee to
65394f8
Compare
vincentkoc
force-pushed
the
fix/libterminal-fanout-lifecycle-20261103
branch
from
November 3, 2026 12:49
44fb4e3 to
6a63ce5
Compare
vincentkoc
force-pushed
the
fix/libterminal-output-ack-chunks-20261103
branch
from
November 3, 2026 12:51
65394f8 to
6e29409
Compare
vincentkoc
force-pushed
the
fix/libterminal-fanout-lifecycle-20261103
branch
from
November 3, 2026 12:51
6a63ce5 to
45bf12b
Compare
Base automatically changed from
fix/libterminal-fanout-lifecycle-20261103
to
main
November 3, 2026 12:54
vincentkoc
force-pushed
the
fix/libterminal-output-ack-chunks-20261103
branch
from
November 3, 2026 12:54
6e29409 to
26d6468
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Output larger than one MiB generated an acknowledgement that the same library rejected, leaving flow-control debt or forwarding acknowledgement text as terminal input. Share the existing decoder limit with the sender and split acknowledgements into accepted chunks. Cover immediate and forwarded acknowledgement modes plus exact and multi-chunk boundaries. Production delta: +7 lines. No wire-schema or public API change.
Validation
26d646863a5bdfe6cd1ffbc6e5a02b2f56ac61d1.cf8f1eeddf1d0da75d2bdeef07797627ee39464b. Rebased code and test patches were verified unchanged.