Repository navigation
fix(stream): complete fanout mutations before callbacks - #147
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
marked this pull request as ready for review
November 3, 2026 12:46
vincentkoc
force-pushed
the
fix/libterminal-fanout-lifecycle-20261103
branch
from
November 3, 2026 12:49
44fb4e3 to
6a63ce5
Compare
vincentkoc
force-pushed
the
fix/libterminal-session-id-bom-20261103
branch
from
November 3, 2026 12:49
7dde0ab to
5c0309c
Compare
Base automatically changed from
fix/libterminal-session-id-bom-20261103
to
main
November 3, 2026 12:51
vincentkoc
force-pushed
the
fix/libterminal-fanout-lifecycle-20261103
branch
from
November 3, 2026 12:51
6a63ce5 to
45bf12b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An overflow callback could publish recursively before other subscribers received the current bytes, reversing output order. A throwing callback could also interrupt close and leave subscribers open. Finish queue mutations and teardown before notifications; notify every recorded event and then propagate the first callback error. Preserve per-subscriber overflow/closed event order and stale-handle protection. Three regressions cover nested publication, throwing overflow, and throwing close callbacks. Production delta: +41 lines for the shared lifecycle boundary.
Validation
45bf12b44989a410016478a405bf909d4632814f.44fb4e3c5759b1df275208bcc088793e217ccd69. Rebased code and test patches were verified unchanged.