Repository navigation
fix(protocol): preserve leading BOM in session IDs - #146
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
force-pushed
the
fix/libterminal-session-id-bom-20261103
branch
from
November 3, 2026 12:49
7dde0ab to
5c0309c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A leading U+FEFF in an opaque session ID was silently stripped during frame decoding, routing the frame under a different identity. Use a dedicated UTF-8 decoder that preserves it, while retaining existing JSON BOM handling. Regression tests cover leading and repeated BOMs plus ordinary Unicode. Production delta: +2 lines. This restores the existing round-trip identity contract.
Validation
5c0309c7c05fba1a7f5e185ef684f35b20e7690e.7dde0ab709625788eac644df6a2d6bd819c4cb42. Rebased code and test patches were verified unchanged.