Fix test_pyramids.py little and big_endian - #6464
Merged
Merged
Conversation
pwalczysko
changed the title
Member
|
👍 Good catch Petr! Sounds like the tests ever only worked by chance, relying on pyramids being generated super fast, because the import process itself doesn't wait for the pyramids. |
dominikl
approved these changes
Jul 16, 2026
dominikl
left a comment
dominikl
left a comment
Member
There was a problem hiding this comment.
👍 Thanks Petr. Looks good to me!
This was referenced Jul 17, 2026
Closed
sbesson
reviewed
Jul 27, 2026
|
|
||
| def wait_for_pyramid_file(self, pixels_id, timeout=120): | ||
| pixels_dir = ( | ||
| "/home/omero/workspace/" |
Member
There was a problem hiding this comment.
This means the integration tests will systematically fail in any other environment than https://merge-ci.openmicroscopy.org/jenkins/.
We should review and update this condition, possibly implementing #6470 (comment)
Merged
pwalczysko
added a commit
to pwalczysko/openmicroscopy
that referenced
this pull request
Jul 28, 2026
pwalczysko
added a commit
to pwalczysko/openmicroscopy
that referenced
this pull request
Jul 28, 2026
pwalczysko
added a commit
to pwalczysko/openmicroscopy
that referenced
this pull request
Jul 28, 2026
pwalczysko
added a commit
to pwalczysko/openmicroscopy
that referenced
this pull request
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the persistent failures of the following 3 tests
test/integration/clitest/test_pyramids.py::TestRemovePyramidsFullAdmin::test_remove_pyramids_little_endian.test/integration/clitest/test_pyramids.py::TestRemovePyramidsFullAdmin::test_remove_pyramids_big_endiantest/integration/clitest/test_pyramids.py::TestRemovePyramidsFullAdmin::test_remove_pyramidsWhat this PR does
The test is creating pyramids first, relying on pyramids being written fast and then testing the removal. After move of the devspace testing framework to NFS, the speed of writing pyramid files dropped. This PR adds checks for really checking whether the files have been written to disk first, before the (actually to-be-tested) removal of them starts.
For that purpose, a new helper
wait_for_pyramidswas introduced in e4565f6Testing this PR
Jenkins test
test/integration/clitest/test_pyramids.py::TestRemovePyramidsFullAdmin::test_remove_pyramids_little_endianshould pass.Related reading
The problematic is similar (definitely not fully identical though) to the already opened #6462. On NFS, the speed of writing and deleting files is simply slower than the tests assume.
ToDo:
Possibly remove the hardcoded
pixels_dir = "/home/omero/workspace/OMERO-test-integration/data/Pixels"-> I think I would need another round of investigation to find our how to replace with an env variable (cc @jburel ) .Thanks for any help. Lets see if it works tomorrow during the build.
cc @sbesson @joshmoore @dominikl