Rewrite pyramid tests - #6471
Conversation
|
This needs a total rethink. The replacement of the single-plane-fake file import with an import of a fake file with pyramids included has grave consequences on the whole philosophy of this test suite, which is mainly testing the CLI command Atm, the only reasonable approach seems to be skipping the failing tests here. cc @sbesson |
|
Agreed, this is an example of tests which specifically test and depend on OMERO pyramids. I think skipping them (conditionally to either the configuration or environment) is the best course of action. An additional clarification idea would be to rename the tests e.g. as |
6335ed7 to
6c842aa
Compare
6c842aa to
bf5e0bd
Compare
Thank you @sbesson . Fixes pushed accordingly see the 4 commits above. Also edited the header of this PR to make the situation clear and adding the Include to confirm on Jenkins. |
|
The build https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/lastCompletedBuild/ is not having any failures from the tests in this PR, all pass or skipped as expected.
|

What this PR does
Rewrites pyramid tests in the OmeroPy suite contained inside
pytest test/integration/clitest/test_pyramids.py.As these tests are operating strictly on OMERO-pyramids (under /OMERO/Pixels) and not on pyramids which are part of the imported file, the strategy taken here had to be to skip the tests with clarification, see comment of @sbesson #6471 (comment)
This PR:
@pytest.mark.skipifadmin removepyramidscmd which is operating on OMERO pyramids onlytest_omero_pyramids.pyto make the situation obviousTesting this PR
Check if the tests in the OmeroPy suite contained inside
pytest test/integration/clitest/test_pyramids.pyeither pass or are skipped.Related reading
Note this is related to #6470