Repository navigation
chore: remove the demo Rails app, update CI and dependencies - #3
Merged
Merged
Conversation
The SDK becomes a bare library on the way to the next API: - remove the Rails playground (test/dummy, bin/playground, lib/octaspace/playground), MockTransport, the Rails Engine and the Appraisal/Rails matrix; the Railtie stays (no Rails dependency) - require Ruby >= 3.3 (3.2 is EOL); CI tests 3.3, 3.4 and 4.0 - CI: actions pinned to commit SHAs, read-only token, concurrency, runs on main and next and on every PR, strict gem build, bundler-audit job - Dependabot for bundler and actions, targeting next, 3-day cooldown - faraday >= 2.14.3 (fixes published advisories); minitest 6, current webmock/standard/rake; railties and puma removed - docs/GIT_WORKFLOW_NEXT.md: how to work with the next branch
secretpray
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK becomes a plain library, and CI and dependencies are brought up to date. No change to the SDK's runtime behaviour.
Removed
test/dummy,bin/playground,lib/octaspace/playgroundand their testsTransport::MockTransportand the RailsOctaSpace::EngineAppraisals,gemfiles/*and the Rails 7.1/7.2/8.0 matrix;railties/pumadev dependencies. TheRailtiestays (it needs no Rails dependency)CI (
.github/workflows/ci.yml)permissions: contents: read,persist-credentials: false, concurrency cancels outdated runsactions/checkoutv7.0.1,ruby/setup-rubyv1.336.0gem build --strictsecurityjob:bundle-audit check --updateDependencies
required_ruby_version >= 3.3(3.2 is end of life)faraday >= 2.14.3, < 3: earlier 2.x versions have published advisoriesconnection_pool2.x and 3.x allowedVerification
bundle exec rake teston Ruby 3.3, 3.4 and 4.0: 0 failuresstandardrb,bundle-audit check --updateandgem build --strict: clean