Repository navigation
feat!: bearer authentication, typed API errors and safe retries - #4
Merged
Merged
Conversation
The SDK becomes a bare library on the way to the next API: - remove the Rails playground (test/dummy, bin/playground, lib/octaspace/playground), MockTransport, the Rails Engine and the Appraisal/Rails matrix; the Railtie stays (no Rails dependency) - require Ruby >= 3.3 (3.2 is EOL); CI tests 3.3, 3.4 and 4.0 - CI: actions pinned to commit SHAs, read-only token, concurrency, runs on main and next and on every PR, strict gem build, bundler-audit job - Dependabot for bundler and actions, targeting next, 3-day cooldown - faraday >= 2.14.3 (fixes published advisories); minitest 6, current webmock/standard/rake; railties and puma removed - docs/GIT_WORKFLOW_NEXT.md: how to work with the next branch
Transport for the next API (api-dev.octa.space): - Authorization: Bearer <api_key>; a pasted "Bearer " prefix and whitespace are stripped; 401 with a non-octa_ak_ key explains that legacy tokens are refused - per-endpoint auth mode: :required raises AuthenticationError before any request when no key is configured, :optional sends the key when present, :none never sends it - default base URL https://api-dev.octa.space (BASE_URL_DEV); the production hosts still serve the legacy API - errors: 400 -> ValidationError, 409 -> ConflictError, 503 -> ServiceUnavailableError; message taken from {"message"}; ApiError exposes retry_after, rate_limit and body - RateLimit-* headers parsed into OctaSpace::RateLimit, the latest available as client.rate_limit; Retry-After as seconds or HTTP date - retries only for GET and idempotent requests, on network errors and 429/502/503/504, honouring Retry-After up to max_retry_after (60 s); POST start/restart are never retried - failover across base_urls only for GET; a request that changes state is never sent to a second host - JSON parsed by the SDK: empty 202/204 bodies are fine, a non-JSON 2xx body raises ApiError - logging is one line per request; headers (API key) and bodies are never logged, and on_request no longer sees headers - faraday-retry dependency removed
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #3. Authentication, error handling, retries and logging of the transport layer.
Authentication
Authorization: Bearer <api_key>. A value that already starts withBearerand surrounding whitespace are normalizedAuthenticationErroris raised before the request when no key is configuredocta_ak_adds a hint on where to create an API keyBase URL
https://api-dev.octa.spacebase_urlis keptErrors
ValidationErrorAuthenticationErrorPermissionErrorNotFoundErrorConflictError(new)RateLimitErrorServiceUnavailableErrorServerError(BadGatewayError502,GatewayTimeoutError504)ApiError#retry_after,#rate_limit,#body,#request_idApiError, not a parsing exceptionRate limits and retries
RateLimit-Limit/Remaining/Reset→OctaSpace::RateLimit; the latest value isclient.rate_limitRetry-Afteris read as seconds (a fraction is rounded up) or as an HTTP datemax_retry_interval(10 s)Retry-Afteris honoured up tomax_retry_after(60 s); a longer wait, such as the restart cooldown, is raised to the callerbase_urlsapplies only to GET on network errors. A request that changes state is never sent to a second host; previously a POST could be repeated on the next URL.Other
[OctaSpace] GET https://… -> 200 (12 ms)). Headers and bodies are never logged; previously Faraday's logger printed theAuthorizationheader.on_requestno longer receives headers.faraday-retrydependency removedVerification
bundle exec rake teston Ruby 3.3, 3.4 and 4.0: 0 failures. New tests cover authentication modes, the retry policy,Retry-Afterlimits, GET-only failover, 202/204, invalid JSON, the key hint, and that the key never reaches logs or hooksstandardrb: clean