Skip to content

test: deflake recent CI failures #66887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panva wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: deflake recent CI failures #66887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2901efd
test: deflake test-http-agent-keepalive
panva Oct 21, 2026
2e1948b
test: handle stringbytes allocation failures
panva Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/addons/stringbytes-external-exceed-max/test-stringbytes-external-at-max.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ try {
buf = Buffer.allocUnsafe(kStringMaxLength);
} catch (e) {
// If the exception is not due to memory confinement then rethrow it.
if (e.message !== 'Array buffer allocation failed') throw (e);
if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED' &&
e.message !== 'Array buffer allocation failed') throw (e);
common.skip(skipMessage);
}

Expand Down
3 changes: 2 additions & 1 deletion ...addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-ascii.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ try {
buf = Buffer.allocUnsafe(kStringMaxLength + 1);
} catch (e) {
// If the exception is not due to memory confinement then rethrow it.
if (e.message !== 'Array buffer allocation failed') throw (e);
if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED' &&
e.message !== 'Array buffer allocation failed') throw (e);
common.skip(skipMessage);
}

Expand Down
3 changes: 2 additions & 1 deletion ...ddons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-base64.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ try {
buf = Buffer.allocUnsafe(kStringMaxLength + 1);
} catch (e) {
// If the exception is not due to memory confinement then rethrow it.
if (e.message !== 'Array buffer allocation failed') throw (e);
if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED' &&
e.message !== 'Array buffer allocation failed') throw (e);
common.skip(skipMessage);
}

Expand Down
3 changes: 2 additions & 1 deletion ...ddons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ try {
buf = Buffer.allocUnsafe(kStringMaxLength + 1);
} catch (e) {
// If the exception is not due to memory confinement then rethrow it.
if (e.message !== 'Array buffer allocation failed') throw (e);
if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED' &&
e.message !== 'Array buffer allocation failed') throw (e);
common.skip(skipMessage);
}

Expand Down
3 changes: 2 additions & 1 deletion test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ try {
buf = Buffer.allocUnsafe(kStringMaxLength + 1);
} catch (e) {
// If the exception is not due to memory confinement then rethrow it.
if (e.message !== 'Array buffer allocation failed') throw (e);
if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED' &&
e.message !== 'Array buffer allocation failed') throw (e);
common.skip(skipMessage);
}

Expand Down
3 changes: 2 additions & 1 deletion .../addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-utf8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ try {
buf = Buffer.allocUnsafe(kStringMaxLength + 1);
} catch (e) {
// If the exception is not due to memory confinement then rethrow it.
if (e.message !== 'Array buffer allocation failed') throw (e);
if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED' &&
e.message !== 'Array buffer allocation failed') throw (e);
common.skip(skipMessage);
}

Expand Down
3 changes: 2 additions & 1 deletion test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ try {
buf = Buffer.allocUnsafe(kStringMaxLength + 2);
} catch (e) {
// If the exception is not due to memory confinement then rethrow it.
if (e.message !== 'Array buffer allocation failed') throw (e);
if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED' &&
e.message !== 'Array buffer allocation failed') throw (e);
common.skip(skipMessage);
}

Expand Down
3 changes: 2 additions & 1 deletion test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ try {
buf = Buffer.allocUnsafe(kStringMaxLength * 2 + 2);
} catch (e) {
// If the exception is not due to memory confinement then rethrow it.
if (e.message !== 'Array buffer allocation failed') throw (e);
if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED' &&
e.message !== 'Array buffer allocation failed') throw (e);
common.skip(skipMessage);
}

Expand Down
12 changes: 6 additions & 6 deletions test/parallel/test-http-agent-keepalive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,13 @@ function remoteClose() {
assert.strictEqual(agent.sockets[name], undefined);
assert.strictEqual(agent.freeSockets[name].length, 1);
assert.strictEqual(agent.totalSocketCount, 1);
// Waiting remote server close the socket
setTimeout(common.mustCall(() => {
// Wait for the remote server to close the socket.
req.socket.once('close', common.mustCall(() => {
assert.strictEqual(agent.sockets[name], undefined);
assert.strictEqual(agent.freeSockets[name], undefined);
assert.strictEqual(agent.totalSocketCount, 0);
remoteError();
}), common.platformTimeout(200));
}));
}));
}));
}));
Expand All @@ -115,13 +115,13 @@ function remoteError() {
assert.strictEqual(agent.sockets[name].length, 1);
assert.strictEqual(agent.freeSockets[name], undefined);
assert.strictEqual(agent.totalSocketCount, 1);
// Wait socket 'close' event emit
setTimeout(common.mustCall(() => {
// Wait for the socket's 'close' event.
req.socket.once('close', common.mustCall(() => {
assert.strictEqual(agent.sockets[name], undefined);
assert.strictEqual(agent.freeSockets[name], undefined);
assert.strictEqual(agent.totalSocketCount, 0);
server.close();
}), common.platformTimeout(1));
}));
}));
}

Expand Down
Loading