Repository navigation
Conversation
The cleanup assertions can run before the socket closes when I/O is delayed. Wait for the socket's close event in both the remote-close and remote-error paths. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Buffer.allocUnsafe() can throw ERR_MEMORY_ALLOCATION_FAILED under memory pressure. Accept it alongside the V8 allocation-failure message so the tests take their intended low-memory skip. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
added
flaky-test
nodejs-github-bot
added
addons
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66887 +/- ##
=======================================
Coverage 90.57% 90.58%
=======================================
Files 797 797
Lines 278362 278362
Branches 53497 53502 +5
=======================================
+ Hits 252138 252146 +8
+ Misses 16574 16565 -9
- Partials 9650 9651 +1 🚀 New features to boost your workflow:
|
richardlau
approved these changes
Oct 21, 2026
panva
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
panva
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
lpinca
approved these changes
Oct 21, 2026
panva
added
the
commit-queue
gurgunday
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deflake tests found during the October 17–21 CI sweep that aren't addressed by other PRs yet:
parallel/test-http-agent-keepalive: wait for socket closure before checking agent state.addons/stringbytes-external-exceed-max/*: recognizeERR_MEMORY_ALLOCATION_FAILEDfor the existing low-memory skip.E.g.