Repository navigation
Feat multi model processing - #477
Conversation
pass a list of model files and get back a single tibble object of all models concatenated together
…ppended to converted outputs
Test against two SS3 models and a combination of SS3 and Rceattle models.
Multimodel data processing is now handled natively by `convert_output`
Verify that `filter_data` works on two models and that ` plot_spawning_biomass` generates a plot with two lines.
…rs alongside multiple models
…ner1/stockplotr into feat-multi-model-processing
|
I believe this still requires a decision regarding how to handle key quantity exporting and caption/alt text when multiple models are present in a plot. |
|
@sbreitbart-NOAA @Schiano-NOAA I think this is ready to review, minus the issues about multi-model key quantities and captions/alt-text but I think that needs to be a separate PR anyway. |
|
As a note, when plotting multiple models, all models need to have the same module plotted at a given time. This is a problem now where each model type (SS3, Rceattle, BAM, etc.) each have slightly different modules associated with particular labels, but this should be standardized across models at some point. |
|
Sounds good! This is getting put in my queue along with your other PR. Hoping to get to it Monday |
Schiano-NOAA
left a comment
There was a problem hiding this comment.
The code looks good to me. I need to run this locally and try it out but in the meantime there are a couple things to address. devtools::document will need to be run again and I think you might need a rebase too before merge.
I will also take a look at the failing checks once these things have been done
|
@JZahner1 is the "Path." argument something special or a normal argument in the functions? I didn't see any reference to it in the code. |
|
@Schiano-NOAA which file? Its probably a typo. |
|
See my comments below but its in all of the conout_[model] functions |
|
I seem them all use |
|
Hmm that's weird. I don't see it in the code anymore |
|
@JZahner1 Also Copilot says this in regards to the failing test: |
|
@JZahner1 Is this ready to merge? |
|
@Schiano-NOAA Not quite. I need to run |
|
@JZahner1 Okay no rush! Just leave a comment when it is please 😄 |
Needed to preserve original fleet names in datasets.
This isn't the problem. The test is expected to throw an error, and it does. I have to remove the surrounding @ericward-noaa how is this test expected to work? I have FIMS installed locally, but I dont understand how |
…ner1/stockplotr into feat-multi-model-processing
|
@Schiano-NOAA This is good to go now. |
…triggered by 5ece022 Merge branch 'feat-multi-model-processing' of https://github.com/JZahner1/stockplotr into feat-multi-model-processing) [skip ci]
What is the feature?
convert_outputto handle multiple models in sequence. This changes from the previous way multiple models were handled (passing a list of tibble outputs fromconvert_output, one per model to each plotting function), but preserves the previous funtionality that allows for plotting multiple models simultaneously. Models are appended together based on amodelcolumn now present in allconvert_outputtibble.This change should improve memory usage, per #457.
How have you implemented the solution?
convert_outputworkflow into apurrr::imapfunction call, allowing for the function to me run sequentially over a list of model files inputs as opposed to a single file.Does the PR impact any other area of the project, maybe another repo?
PR contribution checklist
Thank you for contributing to stockplotr! Please check the boxes below to confirm this pull request (PR) is ready for review. Edit this PR description to add the release indicator and any explanations.