Repository navigation
Fix R CMD check warnings and notes after #477 - #516
Open
ericward-noaa wants to merge 3 commits into
Open
ericward-noaa wants to merge 3 commits into
ericward-noaa wants to merge 3 commits into
Conversation
Regenerated convert_output.Rd, which was missing start_year, and wrapped lines, also correcting file/model to files/models. Fixed @PARAM file. to @PARAM file in conout_bam, conout_rceattle and conout_ss3, which removes the stray Path. argument. Wrote unit, block and predicted_recruitment as .data$ or quoted names rather than adding them to the global variables list
Contributor
Author
|
Minor fixes to remove warnings ready for review @sbreitbart-NOAA @Schiano-NOAA |
Schiano-NOAA
approved these changes
Nov 18, 2026
Schiano-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
One minor comment but otherwise LGTM!
Contributor
Author
|
@Schiano-NOAA fixed here |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated convert_output.Rd, which was missing start_year, and wrapped lines, also correcting file/model to files/models.
Fixed @PARAM file. to @PARAM file in conout_bam, conout_rceattle and conout_ss3, which removes the stray Path. argument.
Wrote unit, block and predicted_recruitment as .data$ or quoted names rather than adding them to the global variables list
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?
PR contribution checklist
Thank you for contributing to stockplotr! Please check the boxes below to confirm this pull request (PR) is ready for review. Edit this PR description to add the release indicator and any explanations.