Skip to content

Fix R CMD check warnings and notes after #477 - #516

Open
ericward-noaa wants to merge 3 commits into
nmfs-ost:mainfrom
ericward-noaa:fix-check-warnings-477
Open

ericward-noaa wants to merge 3 commits into
nmfs-ost:mainfrom
ericward-noaa:fix-check-warnings-477

Conversation

@ericward-noaa

@ericward-noaa ericward-noaa commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Regenerated convert_output.Rd, which was missing start_year, and wrapped lines, also correcting file/model to files/models.

Fixed @PARAM file. to @PARAM file in conout_bam, conout_rceattle and conout_ss3, which removes the stray Path. argument.

Wrote unit, block and predicted_recruitment as .data$ or quoted names rather than adding them to the global variables list

What is the feature?

How have you implemented the solution?

  • above

Does the PR impact any other area of the project, maybe another repo?

  • NA

PR contribution checklist

Thank you for contributing to stockplotr! Please check the boxes below to confirm this pull request (PR) is ready for review. Edit this PR description to add the release indicator and any explanations.

  • I have read and adhered to the contributor guide.
  • I have kept this PR focused on one plot where applicable. For multiple features, I have used separate PRs (stacked PRs are welcome if needed).
  • I have aimed to keep this PR to no more than 750 lines, excluding tests and example data (for example, up to 750 lines for a new function).
  • If I have provided an example dataset, I have explained why the existing sample datasets are not sufficient.
  • I have tested that my changes are compatible with all example outputs in the "data" folder (example_data.rda; pollock.rda; ss3_simple.rda; vermilion_snapper.rda).
  • If I didn't follow the development workflow, I have explained why in this PR.
  • If applicable, I've added the plot to save_all_plots() and updated the associated tests in test-save_all_plots.R.
  • After opening this PR, I have checked that my own tests and spellcheck pass (spelling::spell_check_package()). If other checks fail, I have flagged them for the package maintainers to help diagnose and remedy.
  • I have requested review from one package maintainer (Sam or Sophie).

Regenerated convert_output.Rd, which was missing start_year, and wrapped lines, also correcting file/model to files/models.

Fixed @PARAM file. to @PARAM file in conout_bam, conout_rceattle and conout_ss3, which removes the stray Path. argument.

Wrote unit, block and predicted_recruitment as .data$ or quoted names rather than adding them to the global variables list
@ericward-noaa

Copy link
Copy Markdown
Contributor Author

Minor fixes to remove warnings ready for review @sbreitbart-NOAA @Schiano-NOAA

Comment thread R/conout_bam.R Resolved
Comment thread R/conout_rceattle.R Resolved
Comment thread R/conout_ss3.R Resolved

@Schiano-NOAA Schiano-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but otherwise LGTM!

@ericward-noaa

Copy link
Copy Markdown
Contributor Author

@Schiano-NOAA fixed here

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants