Skip to content

[stable35] fix(suggestion): stop Escape from closing the Viewer - #9584

Merged
blizzz merged 1 commit into
stable35from
fix/esc_close_suggestions
Nov 13, 2026
Merged

blizzz merged 1 commit into
stable35from
fix/esc_close_suggestions

Conversation

@mejo-

@mejo- mejo- commented Nov 10, 2026

Copy link
Copy Markdown
Member

When the emoji, mention or link picker popup was open, pressing Escape closed the whole Viewer instead of just the popup.

The tiptap suggestion plugin handles Escape before the CustomKeymap extension, which normally stops the event from reaching the Viewer. The suggestion handler returns true, so ProseMirror skips the CustomKeymap handler and the event bubbles up to the Viewer.

Stop propagation of Escape in the shared suggestion renderer, including when no popup was rendered.

Fixes: #9482

Assisted-by: ClaudeCode:claude-opus-5-5

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

When the emoji, mention or link picker popup was open, pressing Escape
closed the whole Viewer instead of just the popup.

The tiptap suggestion plugin handles Escape before the CustomKeymap
extension, which normally stops the event from reaching the Viewer. The
suggestion handler returns true, so ProseMirror skips the CustomKeymap
handler and the event bubbles up to the Viewer.

Stop propagation of Escape in the shared suggestion renderer, including
when no popup was rendered.

Fixes: #9482

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo- mejo- self-assigned this Nov 10, 2026
@mejo- mejo- added bug Something isn't working 3. to review labels Nov 10, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Nov 10, 2026
@mejo-

mejo- commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@mejo-

mejo- commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Nov 10, 2026
@blizzz
blizzz merged commit 89c4920 into stable35 Nov 13, 2026
63 of 64 checks passed
@blizzz
blizzz deleted the fix/esc_close_suggestions branch November 13, 2026 15:28
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

2 participants