Repository navigation
[stable35] fix(suggestion): stop Escape from closing the Viewer - #9584
Merged
Merged
Conversation
When the emoji, mention or link picker popup was open, pressing Escape closed the whole Viewer instead of just the popup. The tiptap suggestion plugin handles Escape before the CustomKeymap extension, which normally stops the event from reaching the Viewer. The suggestion handler returns true, so ProseMirror skips the CustomKeymap handler and the event bubbles up to the Viewer. Stop propagation of Escape in the shared suggestion renderer, including when no popup was rendered. Fixes: #9482 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
blizzz
approved these changes
Nov 10, 2026
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the emoji, mention or link picker popup was open, pressing Escape closed the whole Viewer instead of just the popup.
The tiptap suggestion plugin handles Escape before the CustomKeymap extension, which normally stops the event from reaching the Viewer. The suggestion handler returns true, so ProseMirror skips the CustomKeymap handler and the event bubbles up to the Viewer.
Stop propagation of Escape in the shared suggestion renderer, including when no popup was rendered.
Fixes: #9482
Assisted-by: ClaudeCode:claude-opus-5-5
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)