Skip to content

[stable34] fix(suggestion): stop Escape from closing the Viewer - #9597

Merged
mejo- merged 1 commit into
stable34from
backport/9584/stable34
Nov 13, 2026
Merged

mejo- merged 1 commit into
stable34from
backport/9584/stable34

Conversation

@backportbot

@backportbot backportbot Bot commented Nov 13, 2026

Copy link
Copy Markdown

Backport of PR #9584

When the emoji, mention or link picker popup was open, pressing Escape
closed the whole Viewer instead of just the popup.

The tiptap suggestion plugin handles Escape before the CustomKeymap
extension, which normally stops the event from reaching the Viewer. The
suggestion handler returns true, so ProseMirror skips the CustomKeymap
handler and the event bubbles up to the Viewer.

Stop propagation of Escape in the shared suggestion renderer, including
when no popup was rendered.

Fixes: #9482

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@backportbot
backportbot Bot requested a review from blizzz November 13, 2026 15:28
@backportbot backportbot Bot added bug Something isn't working 3. to review labels Nov 13, 2026
@backportbot backportbot Bot added this to the Nextcloud 34.0.7 milestone Nov 13, 2026
@mejo- mejo- changed the title [stable34] [stable35] fix(suggestion): stop Escape from closing the Viewer [stable34] fix(suggestion): stop Escape from closing the Viewer Nov 13, 2026
@mejo-
mejo- merged commit ff6a022 into stable34 Nov 13, 2026
64 checks passed
@mejo-
mejo- deleted the backport/9584/stable34 branch November 13, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant