Skip to content

fix(dialog): let the dialog scroll instead of the form inside it #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Sep 9, 2026
Merged

fix(dialog): let the dialog scroll instead of the form inside it #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/dialog/SharingDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@
* Switch to the confirmation view with the submitted share's link.
*
* @param payload The resolved link and whether it is a public link
* @param payload.link

Check warning on line 158 in lib/dialog/SharingDialog.vue

View workflow job for this annotation

GitHub Actions / eslint 

Missing JSDoc @PARAM "payload.link" description
* @param payload.isPublic

Check warning on line 159 in lib/dialog/SharingDialog.vue

View workflow job for this annotation

GitHub Actions / eslint 

Missing JSDoc @PARAM "payload.isPublic" description
*/
function onSubmitted(payload: { link: string | null, isPublic: boolean }) {
submitResult.value = payload
Expand Down Expand Up @@ -207,15 +207,12 @@
gap: calc(var(--default-grid-baseline) * 3);
}

// Scroll the form (everything but the fixed header/close) once it grows
// tall, so the scrollbar never overlaps the header. A max-height rather than
// flex is used so the dialog still sizes to its content when it is short.
// The dialog scrolls its own content, so the scrollbar sits at its edge
// rather than inside the form. The header stays put while it does.
:deep(.share-panel) {
max-height: 50vh;
// Keep a stable floor so the dialog does not jump around as the content
// changes (switching tabs, adding recipients, revealing toggles).
min-height: min(320px, 50vh);
overflow-y: auto;
}

&__loading,
Expand Down Expand Up @@ -249,6 +246,12 @@
}
}
.sharing-dialog__header {
// The dialog scrolls behind it, so keep the title and the back button in
// place instead of letting them scroll away.
position: sticky;
top: 0;
z-index: 3;
background-color: var(--color-main-background);
display: flex;
align-items: center;
gap: calc(var(--default-grid-baseline) * 2);
Expand Down
Loading