fix(dialog): let the dialog scroll instead of the form inside it - #287
Merged
Merged
Conversation
The form was its own scroll container, so its scrollbar sat inside the dialog's padding and floated over the content. NcDialog already scrolls its content, so the form no longer does, and the header is sticky to stay in place while it scrolls. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
=======================================
Coverage 79.91% 79.91%
=======================================
Files 27 27
Lines 727 727
Branches 202 202
=======================================
Hits 581 581
Misses 127 127
Partials 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The form set its own
max-heightandoverflow-y, which made it a second scroll container nested inside the dialog padding — hence the scrollbar floating over the content with a gap to the dialog border.Fixes #282
NcDialog already scrolls its content (
.dialog__contenthasoverflow: auto), so the form no longer does and that scrollbar is the one you get, at the dialog edge. The form had taken over scrolling to keep the header visible, so the header is sticky now instead.I could not check this against the screenshot myself — worth a look before merging.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.