Repository navigation
feat: registration and API for event editor extensions - #2
Merged
Merged
Conversation
odzhychko
force-pushed
the
registration-and-api
branch
from
November 16, 2026 16:06
f256857 to
d15a509
Compare
odzhychko
marked this pull request as draft
November 16, 2026 17:39
odzhychko
force-pushed
the
registration-and-api
branch
2 times, most recently
from
November 17, 2026 09:54
de3b152 to
54e0c75
Compare
odzhychko
marked this pull request as ready for review
November 17, 2026 10:55
odzhychko
requested review from
ChristophWurst,
SebastianKrupinski and
hamza221
November 17, 2026 11:15
This was referenced Nov 17, 2026
SebastianKrupinski
approved these changes
Nov 17, 2026
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
odzhychko
force-pushed
the
registration-and-api
branch
from
November 18, 2026 08:52
54e0c75 to
af24798
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registration of event editor extensions and first API for Nextcloud Calendar to implement.
Part of nextcloud/calendar#8522
Why the proposed API
As simple example off an extension is:
It differs from the orginal plan in nextcloud/calendar#8522 (comment) for the following reasons:
enforce custom elements mostly just add complexity for implementers of extensions and for the Calendar App
So methods like
addFieldwork just withElementss.implementers can still use the custom elements if they want.
have a
setupfunction (Inspired by Vue hooks)In the originally proposed APIs where more static.
But extensions need to be more dynamic, because event editing is very dynamic.
Editors sizes, property values change and extension need to react to it (e.g. hide fields, expand fields etc.)
Also in the originally proposed API, each field, each
onSavecallback would have been its own extension.Extension authors would have need to coordinate different extension if the wanted to add relate fields (and other extension points).
With the
setupapproach one extension can encapsulate many fields, together withonSavelogic and logic for different editor size etc.🤖 AI (if applicable)