Skip to content

feat: implement support for event editor extensions - #9228

Open
odzhychko wants to merge 1 commit into
8522-event-editor-extension--part-backend-eventsfrom
8522-event-editor-extension--part-frontend-lifecycle
Open

odzhychko wants to merge 1 commit into
8522-event-editor-extension--part-backend-eventsfrom
8522-event-editor-extension--part-frontend-lifecycle

Conversation

@odzhychko

@odzhychko odzhychko commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Part of #8522

Implements the support for extensions in the Calendar App.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.35632% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/mixins/EditorMixin.js 35.00% 9 Missing and 4 partials ⚠️
src/services/eventEditorExtensions/context.ts 87.32% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

@odzhychko
odzhychko force-pushed the 8522-event-editor-extension--part-frontend-lifecycle branch 4 times, most recently from df1fa2c to 86af2f7 Compare November 17, 2026 10:37
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
@odzhychko
odzhychko force-pushed the 8522-event-editor-extension--part-frontend-lifecycle branch from 86af2f7 to 8b54e1b Compare November 17, 2026 11:01
@odzhychko
odzhychko marked this pull request as ready for review November 17, 2026 11:16
Comment thread package.json
"@mdi/svg": "^7.4.47",
"@nextcloud/auth": "^2.6.0",
"@nextcloud/axios": "^2.6.0",
"@nextcloud/calendar": "https://github.com/nextcloud-libraries/nextcloud-calendar/releases/download/v0.0.1-dev.54e0c75/nextcloud-calendar-0.0.1-dev.54e0c75.tgz",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue(blocking): Install package from NPM

Because it's not yet published on NPM the package is used from GitHub artifacts.
See https://github.com/nextcloud-libraries/nextcloud-calendar/releases/tag/v0.0.1-dev.54e0c75

After nextcloud-libraries/nextcloud-calendar#2 and this PR are reviewed, I plan to:

@odzhychko
odzhychko added this pull request to stack #9232 November 18, 2026 08:49
Comment thread src/mixins/EditorMixin.js
// Leaving the editor without closing it, e.g. with the back button of the browser.
// Not if another editor takes over the event, e.g. the full editor from the popover,
// which keeps the extensions set up for it.
const disposeEventEditorExtensionsIfLeavingEditor = () => {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I tried to not change much of the existing code to support the extensions.

Because of that some convoluted code like this exists.

Once we separate out visual editor components, from routing and state it might become cleaner....

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant