Repository navigation
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
odzhychko
force-pushed
the
8522-event-editor-extension--part-frontend-lifecycle
branch
4 times, most recently
from
November 17, 2026 10:37
df1fa2c to
86af2f7
Compare
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
odzhychko
force-pushed
the
8522-event-editor-extension--part-frontend-lifecycle
branch
from
November 17, 2026 11:01
86af2f7 to
8b54e1b
Compare
odzhychko
marked this pull request as ready for review
November 17, 2026 11:16
odzhychko
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
November 17, 2026 11:16
odzhychko
commented
Nov 17, 2026
| "@mdi/svg": "^7.4.47", | ||
| "@nextcloud/auth": "^2.6.0", | ||
| "@nextcloud/axios": "^2.6.0", | ||
| "@nextcloud/calendar": "https://github.com/nextcloud-libraries/nextcloud-calendar/releases/download/v0.0.1-dev.54e0c75/nextcloud-calendar-0.0.1-dev.54e0c75.tgz", |
Contributor
Author
There was a problem hiding this comment.
issue(blocking): Install package from NPM
Because it's not yet published on NPM the package is used from GitHub artifacts.
See https://github.com/nextcloud-libraries/nextcloud-calendar/releases/tag/v0.0.1-dev.54e0c75
After nextcloud-libraries/nextcloud-calendar#2 and this PR are reviewed, I plan to:
- merge feat: registration and API for event editor extensions nextcloud-libraries/nextcloud-calendar#2
- publish
@nextcloud/calendarto npm. - Update this line to use the package from NPM.
- Merge this PR.
odzhychko
commented
Nov 18, 2026
| // Leaving the editor without closing it, e.g. with the back button of the browser. | ||
| // Not if another editor takes over the event, e.g. the full editor from the popover, | ||
| // which keeps the extensions set up for it. | ||
| const disposeEventEditorExtensionsIfLeavingEditor = () => { |
Contributor
Author
There was a problem hiding this comment.
note: I tried to not change much of the existing code to support the extensions.
Because of that some convoluted code like this exists.
Once we separate out visual editor components, from routing and state it might become cleaner....
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8522
Implements the support for extensions in the Calendar App.
🤖 AI (if applicable)