Bug 2074093 - Update detekt's LongParameterList rule to allow up to 9 constructor parameters

gradle/libs.versions.toml

@@ -80,6 +80,8 @@ tomlj = "1.1.1"
 
 # Linters
 androidx-lint = "1.0.0"
+# Fix LongParameterList thresholds to preserve behavior when we update from 1.23.8
+# see - https://github.com/detekt/detekt/issues/3679
 detekt = "1.23.8"
 google-java-format = "1.28.0"
 ktfmt = "0.64"

mobile/android/android-components/components/browser/menu/src/main/java/mozilla/components/browser/menu/item/BrowserMenuImageTextCheckboxButton.kt

@@ -35,7 +35,6 @@ import mozilla.components.support.ktx.android.util.dpToPx
  * @param isInPrimaryState Lambda to return true/false to indicate checkbox primary or secondary state.
  * @param onCheckedChangedListener Callback to be invoked when checkbox is clicked.
  */
-@Suppress("LongParameterList")
 class BrowserMenuImageTextCheckboxButton(
     @DrawableRes imageResource: Int,
     private val label: String,

mobile/android/android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/prompt/PromptRequest.kt

@@ -290,7 +290,6 @@ sealed class PromptRequest(
      * @property onClear callback that is called when the user requests the picker to be clear up.
      * @property onDismiss A callback executed when dismissed.
      */
-    @Suppress("LongParameterList")
     class TimeSelection(
         val title: String,
         val initialDate: java.util.Date,

mobile/android/android-components/components/feature/listentopage/src/main/java/mozilla/components/feature/listentopage/ListenMiddleware.kt

@@ -62,7 +62,6 @@ import mozilla.components.support.ktx.kotlin.stripCommonSubdomains
  * @property ioDispatcher The dispatcher for the work that must not run on the thread the store dispatched on.
  * @property chunker Splits article text into the chunks.
  */
-@Suppress("LongParameterList")
 class ListenMiddleware(
     private val browserStore: BrowserStore,
     private val contentProvider: ContentProvider,

mobile/android/android-components/components/feature/syncedtabs/src/main/java/mozilla/components/feature/syncedtabs/SyncedTabsFeature.kt

@@ -36,7 +36,6 @@ import mozilla.components.support.base.feature.LifecycleAwareFeature
  * @param presenter See [SyncedTabsPresenter].
  * @param interactor See [SyncedTabsInteractor].
  */
-@Suppress("LongParameterList")
 class SyncedTabsFeature(
     context: Context,
     storage: SyncedTabsStorage,

mobile/android/android-components/components/feature/webnotifications/src/main/java/mozilla/components/feature/webnotifications/WebNotificationFeature.kt

@@ -49,7 +49,6 @@ internal const val NOTIFICATION_ID = 1
  * @param activityClass The Activity that the notification will launch if user taps on it
  * @param coroutineContext An instance of [CoroutineContext] used for executing async site permission checks.
  */
-@Suppress("LongParameterList")
 class WebNotificationFeature(
     private val context: Context,
     private val engine: Engine,

mobile/android/android-components/config/detekt.yml

@@ -137,7 +137,9 @@ complexity:
   LongParameterList:
     active: true
     functionThreshold: 8 # (Default: 6) Increased in https://bugzilla.mozilla.org/show_bug.cgi?id=1872996
-    constructorThreshold: 7
+    # threshold of 10 means up to 9 parameters are allowed
+    # this behavior changed in detekt > 1.23.8 see - https://github.com/detekt/detekt/issues/3679
+    constructorThreshold: 10 # Increased in https://bugzilla.mozilla.org/show_bug.cgi?id=2074093
     ignoreDefaultParameters: true # Enabled in https://github.com/mozilla-mobile/android-components/issues/10835
     ignoreDataClasses: true
     ignoreAnnotatedParameter: []

mobile/android/android-components/samples/browser/src/main/java/org/mozilla/samples/browser/integration/ContextMenuIntegration.kt

@@ -26,7 +26,7 @@ import mozilla.components.support.base.feature.LifecycleAwareFeature
 import mozilla.components.ui.widgets.DefaultSnackbarDelegate
 import org.mozilla.samples.browser.databinding.FragmentBrowserBinding
 
-@Suppress("LongParameterList", "UndocumentedPublicClass")
+@Suppress("UndocumentedPublicClass")
 class ContextMenuIntegration(
     context: Context,
     fragmentManager: FragmentManager,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/OpenInAppOnboardingObserver.kt

@@ -28,7 +28,6 @@ import org.mozilla.fenix.ext.nav
 import org.mozilla.fenix.utils.Settings
 
 /** Displays an [InfoBanner] when a user visits a website that can be opened in an installed native app. */
-@Suppress("LongParameterList")
 class OpenInAppOnboardingObserver(
     private val context: Context,
     private val store: BrowserStore,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/IntentProcessors.kt

@@ -29,7 +29,6 @@ import org.mozilla.fenix.perf.lazyMonitored
 import org.mozilla.fenix.shortcut.PasswordManagerIntentProcessor
 
 /** Component group for miscellaneous components. */
-@Suppress("LongParameterList")
 class IntentProcessors(
     private val context: Context,
     private val store: BrowserStore,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/ipprotection/IPProtection.kt

@@ -34,7 +34,6 @@ data class IPProtectionAuthSources(
 )
 
 /** Provides access to IP Protection related components. */
-@Suppress("LongParameterList")
 class IPProtection(
     val engine: Engine,
     val browserStore: BrowserStore,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/middleware/MenuNavigationMiddleware.kt

@@ -63,7 +63,6 @@ import org.mozilla.fenix.webcompat.WebCompatReporterMoreInfoSender
  * @param webCompatReporterMoreInfoSender [WebCompatReporterMoreInfoSender] used to send WebCompat info to
  *   webcompat.com.
  */
-@Suppress("LongParameterList")
 class MenuNavigationMiddleware(
     private val browserStore: BrowserStore,
     private val navController: NavController,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarsIntegration.kt

@@ -33,7 +33,6 @@ import org.mozilla.fenix.utils.Settings
  * @param topToolbarHeight The height of the top toolbar.
  * @param onToolbarsReset Callback to be invoked when the toolbars need to be reset.
  */
-@Suppress("LongParameterList")
 class ToolbarsIntegration(
     private val fullScreenFeature: () -> FullScreenFeature?,
     private val webAppHideToolbarFeature: () -> WebAppHideToolbarFeature?,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/gestures/ToolbarHorizontalGesturesHandler.kt

@@ -42,7 +42,7 @@ import org.mozilla.fenix.ext.components
 import org.mozilla.fenix.ext.maxActiveTime
 
 /** Handles intercepting touch events on the toolbar for swipe gestures and executes the necessary animations. */
-@Suppress("LargeClass", "TooManyFunctions", "LongParameterList")
+@Suppress("LargeClass", "TooManyFunctions")
 class ToolbarHorizontalGesturesHandler(
     private val activity: Activity,
     private val contentLayout: View,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/collections/migration/CollectionsToTabGroupsMigration.kt

@@ -45,7 +45,6 @@ private const val BREADCRUMB_CATEGORY = "CollectionsToTabGroupsMigration"
  * @param ioDispatcher The [CoroutineDispatcher] used for reading the collections' session snapshots from disk and
  *   persisting the migration progress.
  */
-@Suppress("LongParameterList")
 class CollectionsToTabGroupsMigration(
     private val tabCollectionStorage: TabCollectionStorage,
     private val restoreUseCase: TabsUseCases.RestoreUseCase,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/RecentSyncedTabFeature.kt

@@ -46,7 +46,6 @@ import org.mozilla.fenix.components.appstate.AppAction
  * @param ioDispatcher The dispatcher to be used for background IO work.
  * @param currentTimeMillis provider for the current time in milliseconds, injectable for testing.
  */
-@Suppress("LongParameterList")
 class RecentSyncedTabFeature(
     private val context: Context,
     private val appStore: AppStore,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/recentvisits/controller/RecentVisitsController.kt

@@ -59,7 +59,6 @@ interface RecentVisitsController {
 }
 
 /** The default implementation of [RecentVisitsController]. */
-@Suppress("LongParameterList")
 class DefaultRecentVisitsController(
     private val store: BrowserStore,
     private val appStore: AppStore,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/ui/HomeSwipeIntegration.kt

@@ -37,7 +37,6 @@ import org.mozilla.fenix.components.toolbar.gestures.ToolbarHorizontalGesturesHa
  *   out yet.
  * @param tabPreview The [TabPreview] used to display the adjacent tab while swiping.
  */
-@Suppress("LongParameterList")
 class HomeSwipeIntegration(
     private val activity: Activity,
     private val store: BrowserStore,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/history/HistoryView.kt

@@ -26,7 +26,6 @@ import org.mozilla.fenix.library.LibraryPageView
 import org.mozilla.fenix.theme.ThemeManager
 
 /** View that contains and configures the History List */
-@Suppress("LongParameterList")
 class HistoryView(
     container: ViewGroup,
     val store: HistoryFragmentStore,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/recentlyclosed/RecentlyClosedController.kt

@@ -49,7 +49,7 @@ interface RecentlyClosedController {
     fun handleBackPressed(): Boolean
 }
 
-@Suppress("TooManyFunctions", "LongParameterList")
+@Suppress("TooManyFunctions")
 class DefaultRecentlyClosedController(
     private val appStore: AppStore,
     private val navController: NavController,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/BrowserToolbarSearchMiddleware.kt

@@ -153,7 +153,6 @@ internal sealed class EditPageEndActionsInteractions : BrowserToolbarEvent {
  * @param scope [CoroutineScope] used for running long running operations in background.
  * @param autocompleteDispatcher [CoroutineContext] used for querying autocomplete suggestions.
  */
-@Suppress("LongParameterList")
 class BrowserToolbarSearchMiddleware(
     private val uiContext: Context,
     private val appStore: AppStore,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarComposable.kt

@@ -102,7 +102,6 @@ private fun Modifier.awesomeBarContentWidth(useAddressBarFocusMode: Boolean) =
  * @param searchAccessPoint Where search was started from.
  * @param isEdgeToEdgeBackgroundEnabled Whether the Edge2Edge background is enabled.
  */
-@Suppress("LongParameterList")
 class AwesomeBarComposable(
     private val activity: HomeActivity,
     private val fragment: Fragment,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SyncPreferenceView.kt

@@ -31,7 +31,6 @@ import mozilla.components.service.fxa.manager.SyncEnginesStorage
  * @param onReconnectClicked A callback executed when the [syncPreference] is clicked with a preference status of
  *   "Reconnect".
  */
-@Suppress("LongParameterList")
 class SyncPreferenceView(
     private val syncPreference: SyncPreference,
     private val lifecycleOwner: LifecycleOwner,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/datachoices/DataChoicesMiddleware.kt

@@ -23,7 +23,6 @@ import org.mozilla.fenix.ext.nav
 import org.mozilla.fenix.settings.SupportUtils
 import org.mozilla.fenix.utils.Settings
 
-@Suppress("LongParameterList")
 internal class DataChoicesMiddleware(
     private val settings: Settings,
     private val nimbusSdk: NimbusApi,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/logins/ui/LoginsMiddleware.kt

@@ -32,7 +32,6 @@ import org.mozilla.fenix.settings.SupportUtils
  * @param ioDispatcher Coroutine dispatcher for IO operations.
  * @param clipboardManager For copying logins URLs.
  */
-@Suppress("LongParameterList")
 internal class LoginsMiddleware(
     private val loginsStorage: LoginsStorage,
     private val getNavController: () -> NavController,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/studies/StudiesView.kt

@@ -33,7 +33,6 @@ import org.mozilla.fenix.settings.SupportUtils
 import org.mozilla.fenix.settings.SupportUtils.SumoTopic.OPT_OUT_STUDIES
 import org.mozilla.fenix.utils.Settings
 
-@Suppress("LongParameterList")
 class StudiesView(
     private val scope: CoroutineScope,
     private val context: Context,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/trustpanel/store/TrustPanelStore.kt

@@ -25,7 +25,6 @@ class TrustPanelStore(
         reducer = ::reducer,
         middleware = middleware,
     ) {
-    @Suppress("LongParameterList")
     constructor(
         isTrackingProtectionEnabled: Boolean,
         websiteInfoState: WebsiteInfoState,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/summarization/SummarizationStoreViewModel.kt

@@ -45,7 +45,6 @@ import mozilla.components.feature.summarize.summarizationReducer
  *   embedded settings screen.
  * @param errorReporter reports caught exceptions to the crash reporting service.
  */
-@Suppress("LongParameterList")
 class SummarizationStoreViewModel(
     currentTab: SessionState?,
     initializedFromShake: Boolean,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/browser/compose/interactable/InteractableGrid.kt

@@ -175,7 +175,6 @@ interface GridInteractionState {
  * @param ignoredItems List of keys for non-draggable items.
  * @param liveReorderEnabled Whether item reorders should happen 'live' during a drag.
  */
-@Suppress("LongParameterList")
 class GridInteractionStateImpl
 internal constructor(
     private val gridState: LazyGridState,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/browser/compose/interactable/InteractableList.kt

@@ -155,7 +155,6 @@ interface ListInteractionState {
  * @param liveReorderEnabled Whether reordering should happen 'live' while a drag is active.
  * @param onLongPress Optional callback to be invoked when long pressing an item.
  */
-@Suppress("LongParameterList")
 class ListInteractionStateImpl
 internal constructor(
     private val listState: LazyListState,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/browser/compose/legacy/ReorderableList.kt

@@ -82,7 +82,6 @@ fun createListReorderState(
  * @param onLongPress Optional callback to be invoked when long pressing an item.
  * @param onExitLongPress Optional callback to be invoked when the item is dragged after long press.
  */
-@Suppress("LongParameterList")
 class ListReorderState
 internal constructor(
     private val listState: LazyListState,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/redux/middleware/TabStorageMiddleware.kt

@@ -89,7 +89,7 @@ internal data class MutableTabGroup(
  * @param scope The [CoroutineScope] for running the tab data transformation off of the main thread.
  * @param mainScope The [CoroutineScope] used for returning to the main thread.
  */
-@Suppress("LargeClass", "LongParameterList")
+@Suppress("LargeClass")
 class TabStorageMiddleware(
     private val inactiveTabsEnabled: Boolean,
     private val tabGroupsEnabled: Boolean,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/syncedtabs/SyncedTabsIntegration.kt

@@ -33,7 +33,6 @@ import org.mozilla.fenix.tabstray.redux.store.TabsTrayStore
  * @param accountManager An instance of [FxaAccountManager] used for synced tabs authentication.
  * @param lifecycleOwner View lifecycle owner used to determine when to cancel UI jobs.
  */
-@Suppress("LongParameterList")
 class SyncedTabsIntegration(
     private val store: TabsTrayStore,
     private val context: Context,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/wallpapers/WallpapersUseCases.kt

@@ -30,7 +30,6 @@ import org.mozilla.fenix.utils.Settings
  * @param currentLocale The locale currently being used on the device.
  * @param getDisplaySize Returns the current size of the display, in pixels, that a full screen wallpaper has to cover.
  */
-@Suppress("LongParameterList")
 class WallpapersUseCases(
     settings: Settings,
     filesDir: File,
@@ -108,7 +107,6 @@ class WallpapersUseCases(
         suspend operator fun invoke()
     }
 
-    @Suppress("LongParameterList")
     @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
     internal class DefaultInitializeWallpaperUseCase(
         private val appStore: AppStore,

mobile/android/fenix/config/detekt.yml

@@ -140,7 +140,9 @@ complexity:
   LongParameterList:
     active: true
     functionThreshold: 8 # (Default: 6) Increased in https://bugzilla.mozilla.org/show_bug.cgi?id=1872996
-    constructorThreshold: 7
+    # threshold of 10 means up to 9 parameters are allowed
+    # this behavior changed in detekt > 1.23.8 see - https://github.com/detekt/detekt/issues/3679
+    constructorThreshold: 10 # Increased in https://bugzilla.mozilla.org/show_bug.cgi?id=2074093
     ignoreDefaultParameters: true # Enabled in https://github.com/mozilla-mobile/android-components/issues/10835
     ignoreDataClasses: true
     ignoreAnnotatedParameter: []

mobile/android/focus-android/app/src/main/java/org/mozilla/focus/browser/integration/FullScreenIntegration.kt

@@ -27,7 +27,6 @@ import org.mozilla.focus.ext.hide
 import org.mozilla.focus.ext.showAsFixed
 
 /** Integration for the full-screen feature, managing immersive mode and toolbar visibility. */
-@Suppress("LongParameterList")
 class FullScreenIntegration(
     val activity: Activity,
     val store: BrowserStore,

mobile/android/focus-android/quality/detekt.yml

@@ -141,7 +141,9 @@ complexity:
   LongParameterList:
     active: true
     functionThreshold: 8 # (Default: 6) Increased in https://bugzilla.mozilla.org/show_bug.cgi?id=1872996
-    constructorThreshold: 7
+    # threshold of 10 means up to 9 parameters are allowed
+    # this behavior changed in detekt > 1.23.8 see - https://github.com/detekt/detekt/issues/3679
+    constructorThreshold: 10 # Increased in https://bugzilla.mozilla.org/show_bug.cgi?id=2074093
     ignoreDefaultParameters: true # Enabled in https://github.com/mozilla-mobile/android-components/issues/10835
     ignoreDataClasses: true
     ignoreAnnotatedParameter: []