Bug 2074093 - Update detekt's LongParameterList rule to allow up to 9 constructor parameters - #369
Closed
segunfamisa wants to merge 1 commit into
Closed
segunfamisa wants to merge 1 commit into
segunfamisa wants to merge 1 commit into
Conversation
… constructor parameters Note - the behaviour of this rule changed in the next version. For version 1.23.8 we had to set the `constructorThreshold` to 10, to allow 9 parameters. In version 1.23.8, the threshold specifies the number from which a violation is reported, and in newer versions, the threshold specifies the number *after* which, a violation is reported. We should adjust the rule whenever we bump detekt's version. See detekt/detekt#3679 for more info
Contributor
|
View this pull request in Lando to land it once approved. |
Contributor
Author
pollym
approved these changes
Sep 25, 2026
pollym
left a comment
pollym
left a comment
Contributor
There was a problem hiding this comment.
😍 beautiful.... thank you!
|
Pull request closed by commit 04a8b86 |
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 27, 2026
… constructor parameters r=pollymce Note - the behaviour of this rule changed in the next version. For version 1.23.8 we had to set the `constructorThreshold` to 10, to allow 9 parameters. In version 1.23.8, the threshold specifies the number from which a violation is reported, and in newer versions, the threshold specifies the number *after* which, a violation is reported. We should adjust the rule whenever we bump detekt's version. See detekt/detekt#3679 for more info Pull request: #369
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note - the behaviour of this rule changed in the next version. For version 1.23.8 we had to set the
constructorThresholdto 10, to allow 9 parameters.In version 1.23.8, the threshold specifies the number from which a violation is reported, and in newer versions, the threshold specifies the number after which, a violation is reported.
We should adjust the rule whenever we bump detekt's version.
See detekt/detekt#3679 for more info
Lando: link
Bugzilla: bug 2074093
🚫 This pull request has 1 blocker.