Skip to content

Fix two HIGH-severity tutorial bugs (CMake example + rviz image publisher) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmmarinho merged 2 commits into from
Sep 14, 2026
Merged

Fix two HIGH-severity tutorial bugs (CMake example + rviz image publisher) #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10bc120
Fix two HIGH-severity tutorial bugs
Sep 14, 2026
e45edbb
Delete ISSUES.md
mmmarinho Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions cmake_tutorial_workspace/src/cpp_cmake_example_qpoases_lib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
cmake_minimum_required(VERSION 3.5)

project(test_proxsuite)
project(test_qpoases)

set(CMAKE_CXX_STANDARD 20)

FIND_PACKAGE(Eigen3 REQUIRED)
INCLUDE_DIRECTORIES(${EIGEN3_INCLUDE_DIR})
ADD_COMPILE_OPTIONS(-Werror=return-type
-Wall -Wextra -Wmissing-declarations
-Wredundant-decls -Woverloaded-virtual)

add_executable(${PROJECT_NAME}
${PROJECT_NAME}.cpp)
src/${PROJECT_NAME}.cpp)

target_link_libraries(${PROJECT_NAME}
qpOASES
Expand Down
6 changes: 3 additions & 3 deletions docs/source/cmake/cmake_packages_without_sudo.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ This example shows how to build and install the qpOASES to be used in your CMake


.. warning::
This example assumes you have git, CMake, Eigen, and a C++ compiler installed in your GNU/Linux distribution.
This example assumes you have git, CMake, and a C++ compiler installed in your GNU/Linux distribution.


To install qpOASES as a shared library, we use the instructions provided by the DQ Robotics in \
Expand Down Expand Up @@ -95,11 +95,11 @@ Example: include and link the qpOASES in your project
.. literalinclude:: ../../../cmake_tutorial_workspace/src/cpp_cmake_example_qpoases_lib/CMakeLists.txt
:language: cmake
:linenos:
:emphasize-lines: 17
:emphasize-lines: 15

.. tab-item:: test_qpoases.cpp

:download:`test_dqrobotics.cpp <../../../cmake_tutorial_workspace/src/cpp_cmake_example_qpoases_lib/src/test_qpoases.cpp>`
:download:`test_qpoases.cpp <../../../cmake_tutorial_workspace/src/cpp_cmake_example_qpoases_lib/src/test_qpoases.cpp>`

.. literalinclude:: ../../../cmake_tutorial_workspace/src/cpp_cmake_example_qpoases_lib/src/test_qpoases.cpp
:language: cpp
Expand Down
5 changes: 3 additions & 2 deletions docs/source/transformations/rviz.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,10 @@ The integrated sample can be executed as follows.

.. code-block:: console

ros2 run rqt_image_view image_publisher
ros2 run image_publisher image_publisher_node /path/to/lenna.png \
--ros-args -r image_raw:=/images

.. tab-item:: Terminal 2: Run the bridge
.. tab-item:: Terminal 2: Run the visualiser

.. code-block:: console

Expand Down
Loading