Skip to content

test: skip yarn-berry example runs on Node 20 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into from
Oct 5, 2026
Merged

test: skip yarn-berry example runs on Node 20 #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/integration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ test('should generate a project with JavaScript and without GHA', async ({ run,
});

test('should generate be able to run TS examples successfully', { lock: 'apt-get' }, async ({ run, dir, exec, packageManager }) => {
test.skip(packageManager === 'yarn-berry' && process.version.startsWith('v20.'), 'Playwright ESM loader cannot be loaded from the Yarn PnP cache on Node 20');

@yury-s Yury Semikhatsky (yury-s) Oct 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 20 is EOL'ed, why would we support create-playwright for it, let's just update the bots.

test.slow();
await run([], { installGitHubActions: false, testDir: 'tests', language: 'TypeScript', installPlaywrightDependencies: false, installPlaywrightBrowsers: true });
expect(fs.existsSync(path.join(dir, 'tsconfig.json'))).toBeTruthy();
Expand Down Expand Up @@ -127,6 +128,7 @@ test('should not overwrite an existing tsconfig.json', async ({ run, dir }) => {
});

test('should generate be able to run JS examples successfully', { lock: 'apt-get' }, async ({ run, dir, exec, packageManager }) => {
test.skip(packageManager === 'yarn-berry' && process.version.startsWith('v20.'), 'Playwright ESM loader cannot be loaded from the Yarn PnP cache on Node 20');
test.slow();
await run([], { installGitHubActions: false, testDir: 'tests', language: 'JavaScript', installPlaywrightDependencies: false, installPlaywrightBrowsers: true });
expect(fs.existsSync(path.join(dir, 'tests/example.spec.js'))).toBeTruthy();
Expand Down
Loading