Repository navigation
test: skip yarn-berry example runs on Node 20 - #185
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoOct 5, 2026
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
Pavel Feldman (pavelfeldman) merged 1 commit into
Conversation
| }); | ||
|
|
||
| test('should generate be able to run TS examples successfully', { lock: 'apt-get' }, async ({ run, dir, exec, packageManager }) => { | ||
| test.skip(packageManager === 'yarn-berry' && process.version.startsWith('v20.'), 'Playwright ESM loader cannot be loaded from the Yarn PnP cache on Node 20'); |
There was a problem hiding this comment.
Node 20 is EOL'ed, why would we support create-playwright for it, let's just update the bots.
Pavel Feldman (pavelfeldman)
merged commit Oct 5, 2026
6831799
into
microsoft:main
10 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build (20.x, ubuntu-latest)andbuild (20.x, macos-latest)jobs fail onmainbecause, on Node 20,yarn playwright testcannot load Playwright's ESM loader from the Yarn PnP zip cache (ERR_MODULE_NOT_FOUND .../playwright/lib/transform/esmLoader.js). Skip the two "run examples" tests for yarn-berry on Node 20; everything else still runs there.