Repository navigation
fix: ensure non-TTY agents dont hang - #172
Merged
Merged
Conversation
Dmitry Gozman (dgozman)
approved these changes
Apr 2, 2026
| @@ -34,6 +34,7 @@ program | |||
| .option('--quiet', 'do not ask for interactive input prompts') | |||
| .option('--gha', 'install GitHub Actions') | |||
Contributor
There was a problem hiding this comment.
Simon Knott (@Skn0tt) I think there's still not a --no-gha flag for non-interactive rejection of GitHub Actions workflow files, as I mentioned here:
Contributor
Author
There was a problem hiding this comment.
I don't think that's needed, GitHub Actions workflow files are off unless --gha is passed. So --no-gha is the default.
Contributor
There was a problem hiding this comment.
that requires the --quiet flag, which hides the defaults
it's less obvious what this does:
pnpm create playwright --browser=chromium --test-dir=playwright --quietit would be easier to understand if you can just exhaustively pass in all options (this would break after your PR):
pnpm create playwright --browser=chromium --test-dir=playwright --no-ghawe're getting into the same conversation territory in the new PR, so I'll continue over here:
Contributor
There was a problem hiding this comment.
The original issues #39986 and #39987 weren't actually resolved by this PR
There may be an option to complete this over here:
Pavel Feldman (pavelfeldman)
added a commit
that referenced
this pull request
Nov 6, 2026
…187) * fix: overwrite prompt, option parsing, workflow and epilogue issues - Ask before overriding existing files in interactive mode again; the check compared relative paths against absolute ones (regression from #172). - Check for conflicting files before installing anything, skip files whose content is unchanged, report paths relative to the cwd and add the `--force` option the error message refers to. - Accept `--lang JavaScript`/`javascript`/`JS`, comma-separated `--browser` lists, and reject unknown values for both. - Install only the selected browsers in the generated workflow. - Only use `cache: "npm"` in the workflow for npm with a package-lock.json; actions/setup-node fails without a lock file. - Match whole `.gitignore` lines, with or without leading/trailing slashes. - Escape `--test-dir` in the generated config and tsconfig.json, and do not expand `$&`-style patterns in template values. - Only suggest an enabled project and existing files in the closing message. Fixes microsoft/playwright#43950 Fixes microsoft/playwright#43951 Fixes microsoft/playwright#43952 Fixes microsoft/playwright#43953 Fixes microsoft/playwright#43954 Fixes microsoft/playwright#43955 Fixes microsoft/playwright#43956 Fixes microsoft/playwright#43957 * test: normalize line endings in new tests on Windows Templates are checked out with CRLF on Windows runners. Also mark the tests that download browsers as slow, like the current directory test. * chore(ci): make Node.js 22 the main version, drop Node.js 20 Node.js 24 and 26 jobs keep running but no longer fail the workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes microsoft/playwright#39986:
createFilesfrom hanging in quiet mode--test-dirflag, which was only configurable interactively before