Repository navigation
fix: overwrite prompt, option parsing, workflow and epilogue issues - #187
Merged
Pavel Feldman (pavelfeldman) merged 3 commits intoNov 6, 2026
Merged
Conversation
- Ask before overriding existing files in interactive mode again; the check compared relative paths against absolute ones (regression from microsoft#172). - Check for conflicting files before installing anything, skip files whose content is unchanged, report paths relative to the cwd and add the `--force` option the error message refers to. - Accept `--lang JavaScript`/`javascript`/`JS`, comma-separated `--browser` lists, and reject unknown values for both. - Install only the selected browsers in the generated workflow. - Only use `cache: "npm"` in the workflow for npm with a package-lock.json; actions/setup-node fails without a lock file. - Match whole `.gitignore` lines, with or without leading/trailing slashes. - Escape `--test-dir` in the generated config and tsconfig.json, and do not expand `$&`-style patterns in template values. - Only suggest an enabled project and existing files in the closing message. Fixes microsoft/playwright#43950 Fixes microsoft/playwright#43951 Fixes microsoft/playwright#43952 Fixes microsoft/playwright#43953 Fixes microsoft/playwright#43954 Fixes microsoft/playwright#43955 Fixes microsoft/playwright#43956 Fixes microsoft/playwright#43957
Templates are checked out with CRLF on Windows runners. Also mark the tests that download browsers as slow, like the current directory test.
Node.js 24 and 26 jobs keep running but no longer fail the workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the open create-playwright bug reports filed in microsoft/playwright.
createFilescompared relative paths against absolute ones (regression from #172, unreleased).--forceoption the error message refers to now exists. Files whose content is unchanged are not conflicts, so re-running with the same options succeeds.--langacceptsjs/ts/JavaScript/TypeScriptin any case;--browseraccepts comma-separated lists. Unknown values for both are rejected with a commander error.cache: "npm"is only emitted for npm with apackage-lock.json;actions/setup-nodefails when the lock file is missing (pnpm, Yarn,package-lock=false)..gitignoreentries match whole lines, with or without leading/trailing slashes (node_modules_cache/no longer counts asnode_modules/,playwright-report/is not duplicated).--test-diris escaped inplaywright.configandtsconfig.json, and template values are inserted with a replacer function so$&patterns are not expanded.--projectand omits the example command/file with--no-examples.Not addressed here (feature requests): microsoft/playwright#43958, microsoft/playwright#43959, microsoft/playwright#43960, microsoft/playwright#43961.
CI
continue-on-error. Node.js 20 is dropped from the CI matrix and the publish workflow (enginesinpackage.jsonis unchanged).build (20.x, …)jobs as required, so it needs updating to the22.xjobs.Testing
tests/generator.spec.ts(in-process, incl. the interactive override prompt) andtests/integration.spec.ts.npx tsc --noEmitpasses;npx playwright test --project npmpasses locally except the two example-run tests, which needsudoforplaywright install-depson my machine (same onmain). pnpm/Yarn projects are covered by CI.