Repository navigation
Preserve provider ordinary-tool history options in native adapter - #18
Merged
Brian Krabach (bkrabach) merged 1 commit intoOct 21, 2026
Merged
Conversation
Collaborator
Author
|
Included in #17, merged as 7607382. GitHub also marked this PR merged because its exact commit is included in that ancestry. The adapter implementation and its regressions are unchanged from this independently reviewed candidate. The combined #17 candidate passed all four Linux/macOS Python jobs, the dedicated native-adapter job, wheel builds and isolated package-import checks. Consolidating the two related corrections preserved the exact tested source while avoiding a duplicate dependency-setup wait. No adapter changes or regression coverage were dropped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current OpenAI provider passes
ordinary_namesinto native history projection, but the optional CLI adapter rejects that keyword before sending a request. Accept the provider's classification and preserve ordinary computer-shaped tool results in both adapter paths; native screenshot failure handling stays in place.Validation against current provider
df44a798: 10 failing-before cases, 52 affected checks passing after, plus independent review with two full fake-wire ordinary-tool cases. Tests cover original call/result identity, unchanged canonical history, native cancellation and attribution, and default native screenshot refusal. The new regressions run in the optional-provider CI lane. No live model calls or provider protocol fields changed.