Skip to content

Settle cancelled live turns and preserve native history options - #17

Merged
Brian Krabach (bkrabach) merged 2 commits into
mainfrom
fix/settle-cancelled-turn-20261021
Oct 21, 2026
Merged

Brian Krabach (bkrabach) merged 2 commits into
mainfrom
fix/settle-cancelled-turn-20261021

Conversation

@bkrabach

@bkrabach Brian Krabach (bkrabach) commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Two narrow defects in live execution are corrected together:

  • An inner manager turn cancelled by a provider, hook, or admission guard now wakes its live owner before rethrowing cancellation. The owner awaits the same task and performs normal cancelled cleanup, preserving generation/input identity and completed tool results without replay or a success event.
  • The optional native adapter accepts the current provider's ordinary_names option and keeps provider-declared ordinary computer-shaped tool results out of native screenshot projection. Default native screenshot failure handling remains in place.

Both changes were independently reviewed in isolation. The cancellation regressions fail before the first fix; ten adapter compatibility cases fail before the second fix against current provider df44a798. Combined local regression checks pass, and the exact combined head passed all CI: Linux/macOS Python 3.11/3.13 each reported 121 passed with 5 optional-provider skips; the dedicated native-adapter job reported 50 passed. Wheel builds and isolated import checks passed. Additional review covered cancellation/dequeue/Stop/new-input races and actual fake-wire ordinary-tool conversion.

No live model calls, protocol-field changes, automatic replay, or production changes were used. This includes and supersedes the separate compatibility candidate in #18; retargeting this PR preserves the already-tested combined source tree.

@bkrabach
Brian Krabach (bkrabach) changed the base branch from main to fix/native-history-options-20261021 October 21, 2026 05:41
@bkrabach
Brian Krabach (bkrabach) force-pushed the fix/settle-cancelled-turn-20261021 branch from fb1ba3f to 62a4a0a Compare October 21, 2026 05:41
@bkrabach Brian Krabach (bkrabach) changed the title Settle live owners when an inner turn is cancelled Settle cancelled live turns and preserve native history options Oct 21, 2026
@bkrabach
Brian Krabach (bkrabach) changed the base branch from fix/native-history-options-20261021 to main October 21, 2026 05:45
@bkrabach
Brian Krabach (bkrabach) merged commit 7607382 into main Oct 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant