Repository navigation
Settle cancelled live turns and preserve native history options - #17
Merged
Brian Krabach (bkrabach) merged 2 commits intoOct 21, 2026
Merged
Conversation
Brian Krabach (bkrabach)
changed the base branch from
main
to
fix/native-history-options-20261021
October 21, 2026 05:41
Brian Krabach (bkrabach)
force-pushed
the
fix/settle-cancelled-turn-20261021
branch
from
October 21, 2026 05:41
fb1ba3f to
62a4a0a
Compare
Brian Krabach (bkrabach)
changed the base branch from
fix/native-history-options-20261021
to
main
October 21, 2026 05:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two narrow defects in live execution are corrected together:
ordinary_namesoption and keeps provider-declared ordinary computer-shaped tool results out of native screenshot projection. Default native screenshot failure handling remains in place.Both changes were independently reviewed in isolation. The cancellation regressions fail before the first fix; ten adapter compatibility cases fail before the second fix against current provider
df44a798. Combined local regression checks pass, and the exact combined head passed all CI: Linux/macOS Python 3.11/3.13 each reported 121 passed with 5 optional-provider skips; the dedicated native-adapter job reported 50 passed. Wheel builds and isolated import checks passed. Additional review covered cancellation/dequeue/Stop/new-input races and actual fake-wire ordinary-tool conversion.No live model calls, protocol-field changes, automatic replay, or production changes were used. This includes and supersedes the separate compatibility candidate in #18; retargeting this PR preserves the already-tested combined source tree.