Repository navigation
Migrate amplifier-agent worker to the public 0.22 Python binding - #118
Merged
Merged
Conversation
Unqualified migration checkpoint; this is not a claim that the pipeline-runner origin failures are resolved. Verification: adapter 45 passed, 5 skipped; observability 91 passed; timing 11 passed. Runner origin failures remain unresolved. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
9 of 10 tasks
Correct the scoped adapter documentation for public-handle cleanup, persistence-write failures, and observer failures. Add 10 focused tests for the existing failure policy; no runtime behavior changes. Spec context: canonical Attractor §§1.4/4.5 leave backend internals replaceable while graph traversal and String|Outcome/status-file boundaries remain. §4.5's surrounding context catches backend exceptions as FAIL, not success prose. These tests pin existing adapter policy, not a new spec extension. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the default Amplifier Agent worker integration from private Engine/CLI/host-resolution internals to the public
amplifier_agentbinding (create_agent,create_session,start_turn, events, andclose). The public session carries provider/model and effort selection, inherited history, status-file transport, cancellation, and parent-usage bridging. The dependency resolution pins engine 0.22.0, Core 2.0.1, and Foundation21ad50fa40f7acff913cbf6615228ac359f7deddas the narrow co-resolution exception; thegithub-copilotextra remains available. Graph dispatch and the existing nlspec/owned contract surfaces are unchanged.Telemetry now reports actual event selections and cumulative usage snapshots; per-call counts and timing remain unknown where the public API does not expose them. Test isolation keeps the 17 real-routing cases and adds adjacent-cycle restoration checks plus an explicit dev-dependency discriminator.
Verification
8ba837abae57a73ab811c24acdfe52715ef4e7d5passed 13/13 ordinary-word two-node checks. This test-isolation increment was not re-run in DTU, so it is not claimed as fresh runtime qualification.Checklist
CodergenBackendboundary; §4.5 retains the status-file and outcome contract. The surrounding §3.3 edge-selection algorithm and §4.6 human-wait behavior are unchanged; no graph-dispatch change is proposed.ruff check/ruff format --checkclean.specs/EXTENSIONS.md,ledger/, andcontracts/are unchanged; this is a backend replacement within the existing §1.4/§4.5 allowance, not a graph or contract extension.Notes for reviewers
The backend migration does not claim parity for
max_turns, caller-tools passthrough, or unavailable per-call metrics; an explicit positive turn cap fails rather than being silently ignored, and the coding-agent worker remains the alternative when caller tools are required. Two-hex recall remains unknown even when history is delivered; the final ordinary-word pass is not evidence of universal recall.Related documentation correction: amplifier-bundle-attractor PR #361 removes stale fallback guidance and links back here for the runtime behavior.