Repository navigation
Correct default agent worker failure guidance - #361
Merged
Merged
Conversation
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the default-worker guidance in
README.mdanddocs/GETTING-STARTED.md: when--workeris omitted,amplifier-agentis the default; a missing or broken installation fails loudly and does not fall back tollm-direct. The docs now recommend pinning--workerexplicitly in unattended CI. This aligns the existing guidance with the current runner behavior; it changes no runtime, bundle, source-pin, or graph behavior and adds no nlspec extension or observable contract.Verification checklist
pytest modules/loop-pipeline/command names a retired location; the engine moved toamplifier-bundle-dot-runner. This docs-only change was verified with the owning repo's root guard suite: 275 passed, 2 framework-namespaced skips. The mandatory orchestrator source-pin guard passed.AGENTS.mdreviewed; root guard and source-pin gates met.specs/EXTENSIONS.mdentry is needed.Verification evidence
python -m pytest tests/ -q --ignore=tests/e2e: 275 passed, 2 skipped. The mandatory source-pin guard ran and passed. Existing runtime source-of-truth coverage includestest_resolve_no_choice_broken_env_fails_loud_never_degradesandtest_cmd_run_broken_env_fails_loud_never_falls_backinmodules/pipeline-runner/tests/test_default_worker.py.Notes for reviewers
Related runtime migration: amplifier-bundle-dot-runner PR #118. The stale
loop-pipelineunit-test command in this PR template is explicitly N/A because that engine module has moved; the remaining applicable documentation and source-pin gates are reported above. No runtime or live-engine check was performed for this docs-only change.