Skip to content

Python: Require expected keys in tool argument evaluation #8560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evan Mattson (moonbox3) merged 2 commits into from
Sep 21, 2026
Merged

Python: Require expected keys in tool argument evaluation #8560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af5334c
Require expected keys in tool argument evaluation
YaoxinHuang Sep 20, 2026
c68ab46
Test missing and explicit-null tool arguments
YaoxinHuang Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/packages/core/agent_framework/_evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,7 +1221,7 @@ def tool_call_args_match(item: EvalItem) -> CheckResult:
for _, actual_args in matching:
if actual_args is None:
continue
if all(actual_args.get(k) == v for k, v in exp.arguments.items()):
if all(k in actual_args and actual_args[k] == v for k, v in exp.arguments.items()):
found = True
break

Expand Down
32 changes: 32 additions & 0 deletions python/packages/core/tests/core/test_local_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from __future__ import annotations

import inspect
import json

import pytest

Expand Down Expand Up @@ -612,6 +613,37 @@ def test_args_mismatch(self):
assert result.passed is False
assert "args mismatch" in result.reason

@pytest.mark.parametrize("as_json", [False, True], ids=["dict", "json"])
@pytest.mark.parametrize(
"arguments, expected_passed",
[
pytest.param({"location": "NYC"}, False, id="missing"),
pytest.param({"location": "NYC", "units": None}, True, id="explicit-null"),
pytest.param({"location": "NYC", "units": "fahrenheit"}, False, id="non-null"),
pytest.param({"location": "NYC", "units": None, "days": 1}, True, id="extra-argument"),
],
)
def test_null_argument_requires_key(self, arguments, expected_passed, as_json):
item = EvalItem(
conversation=[
Message(
"assistant",
[
Content.from_function_call(
"call_weather",
"get_weather",
arguments=json.dumps(arguments) if as_json else arguments,
)
],
)
],
expected_tool_calls=[ExpectedToolCall("get_weather", {"location": "NYC", "units": None})],
)

result = tool_call_args_match(item)

assert result.passed is expected_passed

def test_tool_not_called(self):
item = _make_tool_call_item(
calls=[("get_news", None)],
Expand Down
Loading