Repository navigation
Python: Require expected keys in tool argument evaluation - #8560
Merged
Evan Mattson (moonbox3) merged 2 commits intoSep 21, 2026
Merged
Evan Mattson (moonbox3) merged 2 commits into
Evan Mattson (moonbox3) merged 2 commits into
Conversation
黄耀鑫(Huang Yaoxin) (YaoxinHuang)
temporarily deployed
to
github-app-auth
September 20, 2026 15:55 — with
GitHub Actions
Inactive
黄耀鑫(Huang Yaoxin) (YaoxinHuang)
temporarily deployed
to
github-app-auth
September 20, 2026 15:55 — with
GitHub Actions
Inactive
黄耀鑫(Huang Yaoxin) (YaoxinHuang)
marked this pull request as ready for review
September 20, 2026 15:56
黄耀鑫(Huang Yaoxin) (YaoxinHuang)
had a problem deploying
to
github-app-auth
September 20, 2026 15:56 — with
GitHub Actions
Error
黄耀鑫(Huang Yaoxin) (YaoxinHuang)
requested review from
SergeyMenshykh,
Tao Chen (TaoChenOSU),
Eduard van Valkenburg (eavanvalkenburg),
Giles Odigwe (giles17),
Jose Alvarez (jpalvarezl),
Evan Mattson (moonbox3),
Roger Barreto (rogerbarreto) and
westey (westey-m)
as code owners
September 20, 2026 15:56
黄耀鑫(Huang Yaoxin) (YaoxinHuang)
temporarily deployed
to
github-app-auth
September 20, 2026 15:56 — with
GitHub Actions
Inactive
黄耀鑫(Huang Yaoxin) (YaoxinHuang)
temporarily deployed
to
github-app-auth
September 20, 2026 15:56 — with
GitHub Actions
Inactive
Evan Mattson (moonbox3)
approved these changes
Sep 21, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
tool_call_args_matchaccepts an omitted argument when its expected value isNone, allowing an incorrect tool call to pass local evaluation.Description & Review Guide
The local evaluation tests, core type checks, pre-commit checks, and package build pass. The full repository test suite was not run.
Related Issue
Fixes #8558
Contribution Checklist