Skip to content

[symbolmap] Catch up assessments for recent Go changes - #1352

Merged
Quim Muntal (qmuntal) merged 1 commit into
mainfrom
qmuntal/symbolmap-catchup-20261104
Nov 4, 2026
Merged

Quim Muntal (qmuntal) merged 1 commit into
mainfrom
qmuntal/symbolmap-catchup-20261104

Conversation

@qmuntal

Copy link
Copy Markdown
Member

Summary

Catch up the catalog after the incomplete weekly runs reported in #1327 and #1348. Correct 35 existing assessments for Go changes since the last successful run on October 20.

  • Record wrapped-request opt-outs, subworkflow forwarding gates, standalone skill validators, source formatting, and loop usage aggregation.
  • Update script/source-context notes, agent-tool argument metadata, and canonical response-format targets.
  • Keep genuine differences explicit, including duplicate-skill selection, repeated fan-out delivery, and configuration without a read-back accessor.

This is the agreed catch-up, not a full re-audit of every catalog leaf or a .NET declaration refresh. No SDK or workflow code changes.

Scope and evidence

Reviewed Go 29b3a1a44e68b4905b16b2c45ebf2c04b9819834 through 5d16802b3678a5e1e099cdcadd11c67a46ecc069: 25 SDK commits, 53 API-report entries, 77 exported added members, and 227 commit/file pairs. Independent skills/workflow reviews and the shared agent/provider/tool review have no pending catch-up items.

The applicable .NET source remains pinned to 0c9944cc9f577d51277ac7c55dbc388b60a577af.

Assessments Implementing changes Pinned .NET evidence
Wrapped requests: missing opt-out becomes mapped/adapted; missing getters remain unmapped #1333 Binding extension
Skills: independent validators become mapped; script/context notes and custom-source constructor corrected #1338, #1347 Validators, custom-source pipeline
Final-response-only loop usage: partial becomes mapped #1330 Aggregated usage
Source formatting: unmapped becomes adapted, retaining the empty/null ID distinction #1320 Attribution formatter
Structured output: canonical format package and final-response decoding #1326, #1345 Typed result
Subworkflow gates: partial becomes adapted; record read-back limitations remain explicit #1344 Host forwarding
Fan-out overloads: partial records Go's deliberate once-per-target delivery versus repeated .NET delivery #1336 Builder path, runtime
Agent-tool argument metadata: retain the partial parent-property propagation assessment #1157 Agent function adapter

Preserved the original baseline, declaration identities, extraction markers, all test pairs, and the existing Go-only assessment. The extraction SHA-256 remains 5f130dd58d97c339b8b5fa48d11c5c7249f239148f509f1a7521b507553bb065. No new declarations or unreviewed assessments were promoted.

Validation

  • go -C _catalog run .\cmd\symbolmap reconcile -summary -check passes: no invalid Go targets or unresolved references.
  • git diff --check passes.
  • Metadata and coverage checks confirm all assigned catch-up IDs are accounted for and only assessment fields changed.

Correct 35 assessment leaves for SDK changes since the October 20 maintenance run. Preserve the original baseline, pinned .NET declarations and extraction metadata, and all test pairs. Strict catalog reconciliation and whitespace checks pass.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@qmuntal
Quim Muntal (qmuntal) marked this pull request as ready for review November 4, 2026 06:02
@qmuntal
Quim Muntal (qmuntal) requested a review from a team as a code owner November 4, 2026 06:02
Copilot AI balanced review requested due to automatic review settings November 4, 2026 06:02
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

API consistency review

Result Scope
out of scope internal-only

The PR only changes the _catalog/dotnet-go-sdk-symbol-mapping.json catalog. It has no exported Go API, runtime behavior, or example changes, so no upstream parity review is needed.

Generated by Go API Consistency Review Agent for #1352 · copilot · auto · 14.5 AIC · ⌖ 0.612 AIC · ⊞ 5.1K · ◷

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the catalog-only assessment updates.

No open issues 🎉

What changed in this PR

Updates 35 existing .NET-to-Go catalog assessments to catch up after the incomplete weekly runs reported in #1327 and #1348. This is catalog-only maintenance, with no SDK or workflow code changes.

Changes:

  • Records wrapped-request controls, subworkflow forwarding gates, standalone skill validators, source formatting, and loop usage aggregation.
  • Refreshes structured-output targets, skill source notes, and agent-tool argument metadata.
  • Documents remaining behavioral differences while preserving declaration identities, extraction metadata, and test pairs.
File Description
_catalog/​dotnet-go-sdk-symbol-mapping.json Updates mapping targets, statuses, and notes to reflect recent Go SDK changes.

Review effort: Balanced

@qmuntal
Quim Muntal (qmuntal) added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 4652529 Nov 4, 2026
24 checks passed
@qmuntal
Quim Muntal (qmuntal) deleted the qmuntal/symbolmap-catchup-20261104 branch November 4, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants