Repository navigation
[symbolmap] Validate audit coverage - #1354
Merged
Merged
Conversation
Add flat audit manifests and pinned per-item receipt validation for original assessments, API/member changes, behavioral diffs, and Go-only entries. Freeze the validator and plan before agent execution, and block PR/noop publication when coverage fails. Simplify the maintenance prompt by reusing the existing skill and coverage guide. Refs #1348. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
API consistency review
The PR changes only the symbolmap maintenance workflow, its lock file, and internal symbolmap validation tooling/tests/docs. No exported Go API, framework behavior, or examples are affected, so no parity review is needed.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two critical coverage gaps allow filtered reports and added module-root packages to omit required API/member items while still passing audit checks without their receipts.
2 open issues
What changed in this PR
Adds a structural coverage gate to weekly symbol-map maintenance, addressing incomplete audits reported in #1348. It validates completion before publication without forcing an early-exiting agent to continue; the catalog catch-up in #1352 remains separate.
Changes:
- Adds
audit-planandaudit-checkcommands for frozen review items and source-pinned receipts. - Gates PR/noop publication using a pre-agent-built validator and recorded hashes.
- Adds coverage/provenance regression tests and documents the receipt contract.
| File | Description |
|---|---|
docs/dotnet-go-sdk-feature-comparison.md |
Documents audit plans, receipts, and validation limits. |
.github/workflows/symbolmap-maintenance-weekly.md |
Adds coverage validation and updates review instructions. |
.github/workflows/symbolmap-maintenance-weekly.lock.yml |
Regenerates workflow steps and publication conditions. |
_catalog/cmd/symbolmap/main.go |
Registers audit commands and shares index flags. |
_catalog/cmd/symbolmap/main_test.go |
Adds coverage, provenance, and CLI regression tests. |
_catalog/cmd/symbolmap/audit.go |
Implements plan generation and receipt validation. |
Review effort: Balanced
Quim Muntal (qmuntal)
added a commit
that referenced
this pull request
Nov 4, 2026
Record the diagnostic filter in changes reports and require explicitly unfiltered input when planning an audit. Include exported declarations and members when the module-root package is added, using the canonical package-name helper. Add regressions for filtered report admission and root-member receipts, and clarify the coverage documentation. Addresses review feedback on #1354. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Quim Muntal (qmuntal)
enabled auto-merge
November 4, 2026 09:50
George Adams (gdams)
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is validation-only: it rejects incomplete coverage but does not force an early-exiting agent to continue.
Related to #1348. The catalog catch-up changes in #1352 are not included.
Validation