Repository navigation
[symbolmap] Update symbol mappings for recent agent APIs - #1223
Merged
Quim Muntal (qmuntal) merged 1 commit intoSep 30, 2026
Merged
Quim Muntal (qmuntal) merged 1 commit into
Quim Muntal (qmuntal) merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Quim Muntal (qmuntal)
marked this pull request as ready for review
September 30, 2026 14:07
Quim Muntal (qmuntal)
approved these changes
Sep 30, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Five modified mapping leaves lack the review reference needed to preserve accurate revision provenance.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates .NET-to-Go symbol mappings for recent agent-mode and compaction APIs.
Changes:
- Maps agent-mode controls and notification suppression.
- Maps compaction-backed history configuration and trigger events.
- Corrects the renamed mode accessor note.
| File | Description |
|---|---|
docs/dotnet-go-sdk-symbol-mapping.json |
Updates mappings and review metadata for recent APIs. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "go_symbols": ["agent.InMemoryHistoryProviderConfig.ProvideOutputMessageFilter", "agent/compaction.HistoryProviderConfig.ProvideOutputMessageFilter"], | ||
| "status": "adapted", | ||
| "note": "Filters loaded history through a context-aware, error-returning Go callback; nil passes all loaded messages through." | ||
| "note": "Filters loaded history through a context-aware, error-returning Go callback; nil passes all loaded messages through. The same field is available on the plain and compaction-backed history configs." |
Quim Muntal (qmuntal)
deleted the
symbolmap-maintenance-2026-09-29-4637d1d-b5c561a35d4f6b97
branch
September 30, 2026 18:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Reviewed the weekly symbolmap snapshot with original
page.total = 839assessed leaves, starting at 2026-09-29T14:06:14Z. Added review batchsymbolmap-maintenance-2026-09-29, pinned to .NET assembly metadata commit0c9944cc9f577d51277ac7c55dbc388b60a577af, current Go commit4637d1dde71f9ecfa21d3bd3b243442d005b3db3, and unchanged inventory SHA-256734ff2c4037aa311de95912a256bb7e223ab3fa81a699835a21d27bab90f53ab.AgentModeProvider.SetModeAsync(AgentSession, string, bool, CancellationToken)mappedtoagent/harness/agentmode.Provider.SetModeProvider.SetMode(session, mode, disableNotification bool)supports notification suppression; pinned inventory includes the bool overload and implementation PR #1111 merged the Go API.AgentModeProviderOptions.DisableModeGetToolmappedtoagent/harness/agentmode.Config.DisableModeGetToolAgentModeProviderOptions.DisableModeSetToolmappedtoagent/harness/agentmode.Config.DisableModeSetToolTodoCompletionLoopEvaluator.EvaluateAsync(LoopContext, CancellationToken)unmapped, but note referenced staleModeForSessionaccessorunmapped; note now referencesModeProvider.ModeForSessionwithProvider.Mode; no built-in todo-completion evaluator counterpart was found.InMemoryChatHistoryProviderOptionsadaptedto plain or compaction-backed Go configscompaction.NewHistoryProviderandHistoryProviderConfig, materially completing reducer-backed history-provider parity.InMemoryChatHistoryProviderOptions.ChatReduceradaptedtoagent/compaction.HistoryProviderConfig.StrategyStrategy, matching the reducer-backed storage role.InMemoryChatHistoryProviderOptions.ReducerTriggerEventadaptedtoagent/compaction.HistoryProviderConfig.TriggerEventInMemoryChatHistoryProviderOptions.ChatReducerTriggerEventand constantsBeforeMessagesRetrieval,AfterMessageAddedadapted/mappedtoagent/compaction.HistoryProviderTriggerEventand constantsagent.InMemoryHistoryProviderConfigagent/compaction.HistoryProviderConfigOriginal assessed leaf coverage: 839/839 reviewed. New assessments added: 9 leaves; one existing assessed note corrected; existing filter/state assessments were updated for the new reducer-capable config. API-report entries and recent patch commits were checked against current Go declarations, pinned inventory, reconciliation output, and implementation PR context. Duplicate checks found merged implementation PRs #1092 and #1111 plus closed/unmerged prior mapping PRs #1218 and #1220; no open mapping work was found for these leaves.
Validation:
go mod downloadto restore missing module cache for symbol indexinggo run ./cmd/symbolmap reconcile -summary -checkgit diff --checkOnly
docs/dotnet-go-sdk-symbol-mapping.jsonis committed. The worktree contains an unrelated pre-existing modification to.github/skills/dotnet-symbols/SKILL.md, left unstaged.Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
proxy.golang.orgstorage.googleapis.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.