Skip to content

[symbolmap] Update symbol mappings for recent agent APIs - #1223

Merged
Quim Muntal (qmuntal) merged 1 commit into
mainfrom
symbolmap-maintenance-2026-09-29-4637d1d-b5c561a35d4f6b97
Sep 30, 2026
Merged

Quim Muntal (qmuntal) merged 1 commit into
mainfrom
symbolmap-maintenance-2026-09-29-4637d1d-b5c561a35d4f6b97

Conversation

@microsoft-agent-framework-for-go

Copy link
Copy Markdown
Contributor

Reviewed the weekly symbolmap snapshot with original page.total = 839 assessed leaves, starting at 2026-09-29T14:06:14Z. Added review batch symbolmap-maintenance-2026-09-29, pinned to .NET assembly metadata commit 0c9944cc9f577d51277ac7c55dbc388b60a577af, current Go commit 4637d1dde71f9ecfa21d3bd3b243442d005b3db3, and unchanged inventory SHA-256 734ff2c4037aa311de95912a256bb7e223ab3fa81a699835a21d27bab90f53ab.

Area Declaration Before After Cause / evidence
Agent mode AgentModeProvider.SetModeAsync(AgentSession, string, bool, CancellationToken) Unreviewed inventoried overload mapped to agent/harness/agentmode.Provider.SetMode Recent Go Provider.SetMode(session, mode, disableNotification bool) supports notification suppression; pinned inventory includes the bool overload and implementation PR #1111 merged the Go API.
Agent mode AgentModeProviderOptions.DisableModeGetTool Unreviewed inventoried property mapped to agent/harness/agentmode.Config.DisableModeGetTool Recent Go config exposes the mode-get tool opt-out; pinned inventory includes the .NET property.
Agent mode AgentModeProviderOptions.DisableModeSetTool Unreviewed inventoried property mapped to agent/harness/agentmode.Config.DisableModeSetTool Recent Go config exposes the mode-set tool opt-out; pinned inventory includes the .NET property.
Agent mode TodoCompletionLoopEvaluator.EvaluateAsync(LoopContext, CancellationToken) unmapped, but note referenced stale ModeForSession accessor Still unmapped; note now references Mode Recent Go API rename replaced Provider.ModeForSession with Provider.Mode; no built-in todo-completion evaluator counterpart was found.
History compaction InMemoryChatHistoryProviderOptions Properties mapped only to plain in-memory config; reducer leaves unreviewed Type now adapted to plain or compaction-backed Go configs PR #1092 added compaction.NewHistoryProvider and HistoryProviderConfig, materially completing reducer-backed history-provider parity.
History compaction InMemoryChatHistoryProviderOptions.ChatReducer Unreviewed inventoried property adapted to agent/compaction.HistoryProviderConfig.Strategy Recent Go compaction history provider requires a Strategy, matching the reducer-backed storage role.
History compaction InMemoryChatHistoryProviderOptions.ReducerTriggerEvent Unreviewed inventoried property adapted to agent/compaction.HistoryProviderConfig.TriggerEvent Recent Go config supports before-retrieval and after-add trigger timing.
History compaction InMemoryChatHistoryProviderOptions.ChatReducerTriggerEvent and constants BeforeMessagesRetrieval, AfterMessageAdded Unreviewed inventoried enum/constants adapted/mapped to agent/compaction.HistoryProviderTriggerEvent and constants Recent Go declares package-level trigger enum and matching constants.
History compaction Existing filter/state-key/state-initializer leaves Mapped only to agent.InMemoryHistoryProviderConfig Also reference agent/compaction.HistoryProviderConfig The new compaction-backed config exposes the same filter and session-state fields on the reducer-capable provider.

Original assessed leaf coverage: 839/839 reviewed. New assessments added: 9 leaves; one existing assessed note corrected; existing filter/state assessments were updated for the new reducer-capable config. API-report entries and recent patch commits were checked against current Go declarations, pinned inventory, reconciliation output, and implementation PR context. Duplicate checks found merged implementation PRs #1092 and #1111 plus closed/unmerged prior mapping PRs #1218 and #1220; no open mapping work was found for these leaves.

Validation:

  • go mod download to restore missing module cache for symbol indexing
  • go run ./cmd/symbolmap reconcile -summary -check
  • git diff --check

Only docs/dotnet-go-sdk-symbol-mapping.json is committed. The worktree contains an unrelated pre-existing modification to .github/skills/dotnet-symbols/SKILL.md, left unstaged.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • proxy.golang.org
  • storage.googleapis.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"
    - "storage.googleapis.com"

See Network Configuration for more information.

Generated by Weekly Symbol Mapping Maintenance · copilot · gpt55 · 247.6 AIC · ⌖ 12.9 AIC · ⊞ 24.1K · ◷

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added size:medium At most 100 changed lines across at most 5 files kind:docs Changes documentation or comments labels Sep 29, 2026
@qmuntal
Quim Muntal (qmuntal) marked this pull request as ready for review September 30, 2026 14:07
@qmuntal
Quim Muntal (qmuntal) requested a review from a team as a code owner September 30, 2026 14:07
Copilot AI balanced review requested due to automatic review settings September 30, 2026 14:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Five modified mapping leaves lack the review reference needed to preserve accurate revision provenance.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Updates .NET-to-Go symbol mappings for recent agent-mode and compaction APIs.

Changes:

  • Maps agent-mode controls and notification suppression.
  • Maps compaction-backed history configuration and trigger events.
  • Corrects the renamed mode accessor note.
File Description
docs/​dotnet-go-sdk-symbol-mapping.json Updates mappings and review metadata for recent APIs.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

"go_symbols": ["agent.InMemoryHistoryProviderConfig.ProvideOutputMessageFilter", "agent/compaction.HistoryProviderConfig.ProvideOutputMessageFilter"],
"status": "adapted",
"note": "Filters loaded history through a context-aware, error-returning Go callback; nil passes all loaded messages through."
"note": "Filters loaded history through a context-aware, error-returning Go callback; nil passes all loaded messages through. The same field is available on the plain and compaction-backed history configs."
@qmuntal
Quim Muntal (qmuntal) added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit 2c723bf Sep 30, 2026
55 of 57 checks passed
@qmuntal
Quim Muntal (qmuntal) deleted the symbolmap-maintenance-2026-09-29-4637d1d-b5c561a35d4f6b97 branch September 30, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:docs Changes documentation or comments size:medium At most 100 changed lines across at most 5 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants