Repository navigation
Review symbol mappings in bounded independent batches - #1224
Merged
Merged
Conversation
Delegate API, behavioral-diff, and original-catalog review to a fresh symbolmap-reviewer for each bounded batch. Limit concurrency to two workers and leave duplicate checks, edits, and publication to the main agent. Require per-item pinned evidence, broader declaration lookup after literal-name misses, and direct file reads when code search is throttled. Keep unresolved items pending and verify existing mappings and implementing diffs before editing. Preserve audit scope, preparation, runtime, and permissions. Update the guide and regenerate workflow metadata with gh-aw v0.89.21.
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The new multi-agent orchestration has only local smoke validation and has not yet run in the hosted workflow environment.
Review effort: Balanced
Findings: None
What changed in this PR
Refactors weekly symbol-map auditing into bounded, evidence-backed subagent batches.
Changes:
- Adds independent API, behavioral, and catalog review phases.
- Defines the inline
symbolmap-revieweragent and completion safeguards. - Documents the workflow and updates generated metadata.
| File | Description |
|---|---|
.github/workflows/symbolmap-maintenance-weekly.md |
Adds batched review orchestration and reviewer instructions. |
.github/workflows/symbolmap-maintenance-weekly.lock.yml |
Updates the generated prompt hash. |
docs/dotnet-go-sdk-feature-comparison.md |
Documents the delegated review process. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
George Adams (gdams)
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #1223 and run 36579819302. The prepared API report included the history-persistence option from #1201, but the agent did not complete its assessment after a literal-name lookup missed the different .NET spelling. It also claimed complete coverage despite unfinished review and throttled source searches.
symbolmap-reviewerbatches, with at most two concurrent workers and no recursive delegation.No SDK code, catalog assessments, inventory, preparation steps, runtime configuration, permissions, budgets, or shared pins change. No custom review ledger or publication gate is added. The generated workflow change is limited to prompt metadata.
Validation
gh aw compile symbolmap-maintenance-weekly --strict --no-check-updatepassed twice on current main with zero warnings and reproducible output.The hosted workflow has not been rerun with this change. SDK, provider, E2E, replay, and benchmark tests were not run for this workflow-only update.