fix(sleep): keep train and val splits non-empty - #272
Open
kaluli123123 wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
assign_splitspromised a non-empty validation gate for at least two real tasks, but an all-test hash assignment left both train and validation empty. A val-plus-test assignment had the same invariant gap: topping up train from the only validation task emptied validation.The fallback now prefers spare train or validation tasks and reaches into test only when preserving both required pools is otherwise impossible.
Fixes #271
Validation
uv run --extra dev pytest -q tests/test_split_hardening_2x3.py tests/test_split_wiring.py— 32 passed.PATH=/Users/vam/.local/bin:/usr/bin:/bin:/usr/sbin:/sbin uv run --extra dev pytest -q— 1,499 passed, 11 skipped, 353 subtests passed.uv run --extra dev ruff check skillopt_sleep/mine.py tests/test_split_hardening_2x3.py— passed.git diff --check— passed.Baseline notes
With the normal host PATH, the full suite reports one unrelated failure because the installed Pi CLI resolves to
/opt/homebrew/bin/piwhiletests/test_backend_pi.py::test_default_model_from_envexpects the literal stringpi. The same failure reproduces on pristine upstreammain; excluding the installed Pi CLI from PATH gives the clean full-suite result above. Full-repository Ruff also reports pre-existing lint findings outside these two files; both changed files are clean.