fix: satisfy assign_splits non-empty guarantee when all tasks hash to test - #274
Closed
RohithPariki wants to merge 1 commit into
Closed
fix: satisfy assign_splits non-empty guarantee when all tasks hash to test#274RohithPariki wants to merge 1 commit into
RohithPariki wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing — this duplicates #272 which was opened prior to this PR and covers the same root cause. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #271. When all tasks hash to test, both train and val start empty. To satisfy the non-empty guarantees for val and train, we now reach into test to promote a task instead of silently no-opping. This is logged as
holdout_leaked.