Align legacy rules and reflections with current PHPStan API conventions

[mglaman]

Part 6 of 9 in the legacy-code audit stack (on top of #1036). Brings the oldest rules and reflection classes in line with current PHPStan 2.x API conventions and the patterns the newer code in this repo already uses.

The getStorage() return type extension change that was in this PR moved to #1045. Review found that the union it introduced is not handled by the storage method extensions and collapses when storage classes overlap, so it needs its own tests and a design decision before it lands.

What changed

• PluginManagerInspectionRule migrates from Node\Stmt\Class_ to InClassNode, which provides the ClassReflection directly. The ReflectionProvider constructor dependency, anonymous-class handling, and manual FQN round-trip all disappear. Behavior is unchanged.

• GlobalDrupalDependencyInjectionRule resolves the called class via $scope->resolveName() and checks against the MethodReflection interface instead of ExtendedMethodReflection, which PHPStan marks @api-do-not-implement. One observable change: parent::service() inside a subclass of the non-final \Drupal class is now reported. No such subclass exists in core or this repo.

• EntityFieldReflection guards ReflectionProvider::getClass() with hasClass(); FieldItemListPropertyReflection builds nullable types with TypeCombinator::addNull().

• EntityFieldsViaMagicReflectionExtension uses ClassReflection::is() for the FieldItemListInterface check instead of rebuilding an ObjectType from the class name on every property lookup. An earlier revision used implementsInterface(), which returns false for the interface itself and broke $node->uid->entity. Two public static helpers that only served the old check are removed; no callers exist outside vendored copies of this repo.

• Redundant ->line($node->getStartLine()) calls removed — that is already the default.

• PluginManagerInspectionRule no longer crashes when a plugin manager without a constructor contains an anonymous class that declares one. The constructor lookup searched the class body recursively and picked up the nested one, then getConstructor() threw on the hierarchy. It now uses the class node's own method lookup and guards with hasConstructor(). Pre-existing bug, surfaced by review.

Known but out of scope

• The "must override __construct" branch in PluginManagerInspectionRule is unreachable because the rule returns early unless the class body declares its own constructor. Tracked as a follow-up.

Testing

EntityFieldsViaMagicReflectionExtensionTest gains cases for values typed as FieldItemListInterface itself, which is what $node->uid is. They fail on the implementsInterface() revision and pass now. A new plugin-manager-nested-constructor.php fixture reproduces the crash. Full suite, self-analysis, and phpcs are green.

🤖 Generated with Claude Code