Remove dead code left over from the legacy audit - #1052
Merged
Conversation
The "must override __construct" branch in PluginManagerInspectionRule cannot fire: the rule returns early unless the class declares its own constructor, and then the class is always the declaring class. The entity_test_update install-file ignore and the no_transitions_css skip guard modules that have no .install file or no longer exist in any supported Drupal core version. Closes #1050 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1050. Dead code only, no behavior change and no release-note entry.
What changed
PluginManagerInspectionRule: the "%s must override __construct if using YAML plugins." branch is gone, along with itspluginManagerInspection.constructorOverrideMissingidentifier. Since Align legacy rules and reflections with current PHPStan API conventions #1027 the rule returns early unless the class declares its own constructor, and a class that declares its own constructor is always the declaring class, so the branch could not fire. The YAML inspection now takes only the constructor node it reads.DrupalAutoloader:entity_test_updateis dropped from the ignored install files. The module has no.installfile on 10.4.x, 11.3.x, or 11.4.x.ExtensionDiscovery: theno_transitions_cssskip is gone. The module no longer exists anywhere in core on 10.4.x or later.Checked each module against the drupal/core tree on GitHub for every supported branch before removing.
Testing
Full suite, self-analysis, and phpcs are green.
🤖 Generated with Claude Code