Repository navigation
[windows][build] fix pyml's Windows stubs for OCaml 5 - #2284
Merged
Merged
Conversation
jeremydubreil
marked this pull request as ready for review
October 28, 2026 08:56
Contributor
|
There is a conflict here. |
jeremydubreil
force-pushed
the
patch-pyml-windows
branch
2 times, most recently
from
October 28, 2026 13:51
94721f1 to
854e618
Compare
Contributor
Author
Fixed after rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, infer fails to link, because pyml's Windows stubs still use the names that two primitives of OCaml's
unixlibrary had before OCaml 5.0. This adds a second patch to thepyml.20220905package of infer's local opam repository, applied afterno-stdcompat.patch:pyml_arch.ml.c,win_handle_fdbecomescaml_unix_filedescr_of_fd, its name since OCaml 5.0;pyml_stubs.c, the declaration ofwin_CRT_fd_of_filedescris replaced by#include <caml/unixsupport.h>. That header still provides the old name, through a macro, but pyml declared the function itself, which bypasses the macro.Both changes are in code that is only compiled on Windows, so nothing changes on Linux and macOS.