Repository navigation
[windows][build] patch ANSITerminal for mingw-w64 GCC 14 - #2283
Merged
Merged
Conversation
jeremydubreil
force-pushed
the
patch-ansiterminal
branch
from
October 27, 2026 17:56
22b323e to
f5a2eb6
Compare
jeremydubreil
marked this pull request as ready for review
October 27, 2026 17:57
Contributor
|
There is a conflict in this one now. |
jeremydubreil
force-pushed
the
patch-ansiterminal
branch
from
October 28, 2026 13:51
f5a2eb6 to
931598b
Compare
Contributor
Author
Fixed after rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest release of ANSITerminal, 0.8.5 (July 2022), fails to compile on Windows with mingw-w64 GCC 14, which turned some warnings into errors. This adds
ANSITerminal.0.8.5to infer's local opam repository, with a patch to its Windows-only stubs:_get_osfhandle()was declared as returninglong, which truncates handles to 32 bits on 64-bit Windows; the declaration now comes from<io.h>;<caml/fail.h>was missing, forcaml_raise_with_args();FillConsoleOutputCharacterwas passed anint *where it expects aDWORD *.The patched file is only compiled on Windows, so nothing changes on Linux and macOS.