Skip to content

[Nexthop][feature] "asic_config_v3" - Support multiple management ports - #1714

Open
marif-nexthop wants to merge 3 commits into
meta:mainfrom
nexthop-ai:marif.fboss-asic-config-v3-mgmt-ports
Open

marif-nexthop wants to merge 3 commits into
meta:mainfrom
nexthop-ai:marif.fboss-asic-config-v3-mgmt-ports

Conversation

@marif-nexthop

@marif-nexthop marif-nexthop commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

Implements asic_config_v3 design.

In this PR, add support for more than one management port.

  • mgmt_port_defaults in the ASIC data and mgmt_port_overrides in the platform config become lists with one entry per management port.
  • An override merges onto the defaults entry at the same index; entries beyond the defaults list declare additional ports and must be complete.
  • The generator rejects incomplete additional entries and duplicate logical or physical port identifiers.
  • The Tomahawk5 and Tomahawk6 defaults and the five platform configs that override the management port are converted to the list form.

Also removed the unused core_offset_apply_all key from the platform schema together with the special_core_offset_apply_all mention in the schema field reference, since no generator reads either, and made the generator honor the already documented num_lanes_per_port platform setting.

Test Plan

Ran fboss/lib/asic_config_v3/run-helper.sh to generate asic_config_v3 output:

[3/3] Running utility command for fboss-asic-config-v3-gen.GEN_PY_EXE
Completed build for fboss-asic-config-v3-gen.GEN_PY_EXE
...
Generating ASIC config for icecube800banw/default...
Generating ASIC config for icecube800bc/default...
Generating ASIC config for icetea800bc/default...
Generating ASIC config for ladakh800bcls/rack...
Generating ASIC config for ladakh800bcls/test_fixture...
Generating ASIC config for meru800bia/default...
Generating ASIC config for montblanc/default...
Generating ASIC config for montblanc/hw_test...
Generating ASIC config for tahan800bc/chassis...
Generating ASIC config for tahan800bc/test_fixture...
Generating ASIC config for tahansb800bc/default...
Generating ASIC config for tahansb800bc/test_fixture...
Generating ASIC config for wedge800bact/default...
Generating ASIC config for wedge800bact/hw_test...
...
Configs have been written to specified output directory

The generated output is identical to the checked-in files for every platform

% git status --porcelain fboss/configs/platforms
<no changes>

Validated the ASIC and platform configs against the schemas

% python3 -m fboss.lib.asic_config_v3.test.validate_asic_configs_schemas --fboss-root fboss
...
15 passed, 0 failed

@meta-cla meta-cla Bot added the CLA Signed label Oct 2, 2026
@marif-nexthop
marif-nexthop marked this pull request as ready for review October 2, 2026 20:02
@marif-nexthop
marif-nexthop requested review from a team as code owners October 2, 2026 20:02
@marif-nexthop marif-nexthop changed the title [Nexthop][NPI] "asic_config_v3" - Support multiple management ports [Nexthop][feature] "asic_config_v3" - Support multiple management ports Oct 15, 2026
@github-actions github-actions Bot added the project:feature FBOSS project: feature label Oct 15, 2026
@marif-nexthop
marif-nexthop force-pushed the marif.fboss-asic-config-v3-mgmt-ports branch 2 times, most recently from ff258cc to b8301d8 Compare October 20, 2026 04:33
lotus-nexthop pushed a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
Add m4061nhp's asic_config_v3 input and the SDK yaml generated from it.

Stacked on meta#1837 (platform mapping,
which carries meta#1842, meta#1836 and meta#1828) and
meta#1714 (multiple management ports).
lotus-nexthop pushed a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
Add m4061nhp's asic_config_v3 input and the SDK yaml generated from it,
plus the synced reference validate_asic_configs_contents compares it to.
check-yaml skips synced references, as it already does generated outputs.

Stacked on meta#1837 (platform mapping,
which carries meta#1842, meta#1836 and meta#1828) and
meta#1714 (multiple management ports).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant