Repository navigation
[Nexthop][feature] "asic_config_v3" - Support multiple management ports - #1714
Open
marif-nexthop wants to merge 3 commits into
Open
marif-nexthop wants to merge 3 commits into
marif-nexthop wants to merge 3 commits into
Conversation
marif-nexthop
marked this pull request as ready for review
October 2, 2026 20:02
marif-nexthop
force-pushed
the
marif.fboss-asic-config-v3-mgmt-ports
branch
2 times, most recently
from
October 20, 2026 04:33
ff258cc to
b8301d8
Compare
1 of 2 tasks
lotus-nexthop
pushed a commit
to nexthop-ai/fboss
that referenced
this pull request
Oct 25, 2026
lotus-nexthop
added a commit
to nexthop-ai/fboss
that referenced
this pull request
Oct 25, 2026
lotus-nexthop
pushed a commit
to nexthop-ai/fboss
that referenced
this pull request
Oct 25, 2026
lotus-nexthop
added a commit
to nexthop-ai/fboss
that referenced
this pull request
Oct 25, 2026
Add m4061nhp's asic_config_v3 input and the SDK yaml generated from it, plus the synced reference validate_asic_configs_contents compares it to. check-yaml skips synced references, as it already does generated outputs. Stacked on meta#1837 (platform mapping, which carries meta#1842, meta#1836 and meta#1828) and meta#1714 (multiple management ports).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Implements
asic_config_v3design.In this PR, add support for more than one management port.
mgmt_port_defaultsin the ASIC data andmgmt_port_overridesin the platform config become lists with one entry per management port.Also removed the unused
core_offset_apply_allkey from the platform schema together with thespecial_core_offset_apply_allmention in the schema field reference, since no generator reads either, and made the generator honor the already documentednum_lanes_per_portplatform setting.Test Plan
Ran
fboss/lib/asic_config_v3/run-helper.shto generateasic_config_v3output:The generated output is identical to the checked-in files for every platform
Validated the ASIC and platform configs against the schemas