Skip to content

fix(source-control): isolate the AffectedSuites git fixture from global config #10567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 2 commits into from
Oct 28, 2026
Merged

fix(source-control): isolate the AffectedSuites git fixture from global config #10567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bf98f4
fix(source-control): isolate the AffectedSuites git fixture from glob…
kyle-sexton Oct 28, 2026
87f96b8
Merge branch 'main' into fix/affected-suites-fixture-isolation
kyle-sexton Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/source-control/fix-affected-suites-fixture-isolation-7b3e9d24.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
bump: none
---

Test-only: the `AffectedSuites` fixture ignores the machine's global and system git config, so its `git commit` no longer fails when `commit.gpgsign` is on and signing cannot reach its key; nothing a user runs changes.
7 changes: 7 additions & 0 deletions plugins/source-control/skills/babysit-prs/scripts/tests/test_babysit_postmerge_quarantine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,13 @@ def commit(self, files: dict[str, str], message: str) -> str:
return self.git(self.root, "rev-parse", "HEAD")

def setUp(self) -> None:
# The machine's global config signs commits (commit.gpgsign) through a
# key the fixture cannot reach, which fails `git commit` under load.
env = mock.patch.dict(
os.environ, {"GIT_CONFIG_GLOBAL": os.devnull, "GIT_CONFIG_NOSYSTEM": "1"}
)
env.start()
self.addCleanup(env.stop)
tmp = tempfile.TemporaryDirectory()
self.addCleanup(tmp.cleanup)
self.root = pathlib.Path(tmp.name) / "clone"
Expand Down
Loading