Repository navigation
fix(source-control): isolate the AffectedSuites git fixture from global config - #10567
Conversation
…al config The fixture inherited the machine's global git config. With commit.gpgsign on and SSH signing through an interop script, parallel runs failed `git commit` with "failed to write commit object" (exit 128). Point GIT_CONFIG_GLOBAL at os.devnull and set GIT_CONFIG_NOSYSTEM for the class. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
PR body contract — issue linkage This PR body does not yet satisfy the issue-linkage contract:
Edit the body and this comment updates itself on the next run. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security issues found. The change only touches test fixture setup and adds a changelog fragment.
critical-findings: 0 |
|
claude-review reviewed No findings. I read the full diff (2 files) and the surrounding fixture code.
|
No related issue: flaky fixture seen by two builders on #10498 and #10558
Why
AffectedSuitesintest_babysit_postmerge_quarantine.pyfailedgit commit(exit 128) in parallel runs. The fixture inherited the machine's global git config, wherecommit.gpgsign=truesigns through an interop script that fails under load:error: <3>WSL (...) ERROR: UtilAcceptVsock:273: accept4 failed 110thenfatal: failed to write commit object.What changed
AffectedSuites.setUppatchesGIT_CONFIG_GLOBAL=os.devnullandGIT_CONFIG_NOSYSTEM=1for the class, the same valuestest_babysit_check_inputs.pyandtest_babysit_postmerge_contains.pyalready use.bump: none.Scope
AffectedSuitesclass only. The module-level pop ofGIT_DIR,GIT_WORK_TREEandGIT_CONFIGstays.test_babysit_lane_room.pyandtest_babysit_merge_skip.pyalso rungit commitwithout isolating global config; not reproduced as flaky, so left alone.Verification
babysit-prs/scripts/testsonce: 3287 passed.scripts/check-fixture-git-isolation.sh: OK.Left out: nothing
🤖 Generated with Claude Code