Skip to content

ci(review): repin the review callers to ci-workflows v0.65.14 #10170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 7 commits into from
Oct 26, 2026
Merged

ci(review): repin the review callers to ci-workflows v0.65.14 #10170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8bfda67
ci(review): repin the review callers to ci-workflows v0.65.14
kyle-sexton Oct 26, 2026
eafdcd3
Merge branch 'main' into ci/repin-review-v0.65.14
kyle-sexton Oct 26, 2026
11f2fd9
Merge remote-tracking branch 'origin/main' into ci/repin-review-v0.65.14
kyle-sexton Oct 26, 2026
8ce6ed6
Merge main into ci/repin-review-v0.65.14
melodic-automation-lanes[bot] Oct 26, 2026
5670d64
Merge remote-tracking branch 'origin/main' into ci/repin-review-v0.65.14
kyle-sexton Oct 26, 2026
451a1b9
Merge remote-tracking branch 'origin/ci/repin-review-v0.65.14' into c…
kyle-sexton Oct 26, 2026
10c1fdc
Merge remote-tracking branch 'origin/main' into ci/repin-review-v0.65.14
kyle-sexton Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-review-hosted.yml
View file
Open in desktop

@github-actions github-actions Bot Oct 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head 10c1fdcee55374b6a8239609a6079b76a0158951. What it wrote, as data:

Summary: PR #10170 references #9073 with `Refs:`, so it should deliver only part of that issue. It bumps both review-lane callers from ci-workflows v0.65.13 to v0.65.14. According to the PR body, that release reports a failed install as `install-failed` instead of `no-outcome`. That part is within the issue's scope, and the two-line pin change looks coherent. The verdict is still fail because the body never names the work that remains. #9073 asks that a timed-out install no longer fail a lane without a retry, measured over a week of runs, and a partial delivery must say what is left for later.
- PR body: add a section naming the remaining work on #9073. Name any retry of the timed-out bubblewrap install still to be done. Name the automatic re-run by the status job, unless v0.65.14 already does it, and say whether it does. Name the week-long measurement that the issue's done-when asks for and that the refinement keeps as a follow-up check by a person.
- PR body: state whether the status job treats the new `install-failed` class as infrastructure and re-runs it automatically, the issue's preferred fix. The diff only moves a pin, so the reviewer cannot see this behaviour in this repo.
- scripts/ci-review-lanes.test.sh:79-82: the body says this test expects the new pin, but the diff does not change this file. Either the test does not hardcode the SHA, or it still expects `ba7af78d…` and will fail. Confirm which, and update the test in this PR if it hardcodes the SHA.
- .github/workflows/pr-review-hosted.yml:172 and .github/workflows/pr-review-security-hosted.yml:177: both callers move to `3180217076b19bbdfccc43026c7f91c604da673d` (v0.65.14). The permissions and inputs are unchanged, and the change touches no takeover-set files.

Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ jobs:
contents: read
pull-requests: write # the review, its inline comments and the lane's
# reviewed-head marker comment
uses: melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@ba7af78d291f10bd75651857a0db2357c23df0fe # v0.65.13
uses: melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@3180217076b19bbdfccc43026c7f91c604da673d # v0.65.14
with:
lane: code
publish: comments
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-review-security-hosted.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ jobs:
contents: read
pull-requests: write # the review, its inline comments and the lane's
# reviewed-head marker comment
uses: melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@ba7af78d291f10bd75651857a0db2357c23df0fe # v0.65.13
uses: melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@3180217076b19bbdfccc43026c7f91c604da673d # v0.65.14
with:
lane: security
publish: comments
Expand Down
Loading