Repository navigation
ci(review): repin the review callers to ci-workflows v0.65.14 - #10170
Conversation
v0.65.14 reports a failed "Isolate the runner" install as install-failed instead of no-outcome (ci-workflows#893). Only pr-review-cli.yml and the actions it loads from its own ref changed, so only its two callers move. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security findings. The diff is two lines.
critical-findings: 0 |
|
claude-review reviewed I found nothing to flag in this change, and no closing issue states criteria to check. The PR moves the What I checked with my own tool reads:
Unverified: the PR's test counts (182, 88 and 10 passing) are author-claimed. I did not run them. I also did not inspect the contents of the upstream v0.65.14 release. Cost: this PR spends only prepaid or subscription usage, and no hold applies. |
# Conflicts: # scripts/ci-review-lanes.test.sh
Lane-Activity: pr-unblock/resolve-conflicts
…i/repin-review-v0.65.14
There was a problem hiding this comment.
The pr-verify verifier failed head 10c1fdcee55374b6a8239609a6079b76a0158951. What it wrote, as data:
Summary: PR #10170 references #9073 with `Refs:`, so it should deliver only part of that issue. It bumps both review-lane callers from ci-workflows v0.65.13 to v0.65.14. According to the PR body, that release reports a failed install as `install-failed` instead of `no-outcome`. That part is within the issue's scope, and the two-line pin change looks coherent. The verdict is still fail because the body never names the work that remains. #9073 asks that a timed-out install no longer fail a lane without a retry, measured over a week of runs, and a partial delivery must say what is left for later.
- PR body: add a section naming the remaining work on #9073. Name any retry of the timed-out bubblewrap install still to be done. Name the automatic re-run by the status job, unless v0.65.14 already does it, and say whether it does. Name the week-long measurement that the issue's done-when asks for and that the refinement keeps as a follow-up check by a person.
- PR body: state whether the status job treats the new `install-failed` class as infrastructure and re-runs it automatically, the issue's preferred fix. The diff only moves a pin, so the reviewer cannot see this behaviour in this repo.
- scripts/ci-review-lanes.test.sh:79-82: the body says this test expects the new pin, but the diff does not change this file. Either the test does not hardcode the SHA, or it still expects `ba7af78d…` and will fail. Confirm which, and update the test in this PR if it hardcodes the SHA.
- .github/workflows/pr-review-hosted.yml:172 and .github/workflows/pr-review-security-hosted.yml:177: both callers move to `3180217076b19bbdfccc43026c7f91c604da673d` (v0.65.14). The permissions and inputs are unchanged, and the change touches no takeover-set files.
Refs: #9073
Summary
Repins
pr-review-hosted.ymlandpr-review-security-hosted.ymlto ci-workflowsv0.65.14
(
3180217076b19bbdfccc43026c7f91c604da673d). That release reports a failed "Isolate the runner"install as
install-failedinstead ofno-outcome(ci-workflows#893).
Fix
pr-review-cli.yml,pr-review.yml,pr-review-security.yml,release-tag.ymlandpublish-review, whichpr-review-cli.ymlloads from its own ref (pr-review-cli.yml:3801at3180217). No othercaller here uses those files, so the launcher and action pins stay at v0.65.13.
pr-review-clicontract, which is unchanged.
scripts/ci-review-lanes.test.sh:79-82expects the new pin.Verification
node --test .github/actions/resolve-config/callers.test.mjs: 182 pass, 0 fail.bash scripts/ci-review-lanes.test.sh: 88 pass, 0 fail.bash scripts/ci-review-plugin-source.test.sh: 10 pass, 0 fail.Related
🤖 Generated with Claude Code