Skip to content

fix(i18n): catch keys read through a copyFor() key list #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jouwdan merged 1 commit into from
Sep 20, 2026
Merged

fix(i18n): catch keys read through a copyFor() key list #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions scripts/i18n-check.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ const source = files.filter(
const CALL = /(?:\.\s*(?:t|has)|\bmsg)\(\s*'([\w.-]+)'/g
const CARRIED = /\b(?:title|blurb|label|description|message|publicMessage)Key:\s*'([\w.-]+)'/g
const KEY_SHAPE = /^[a-z][\w-]*(?:\.[\w-]+)+$/
const KEY_LIST = /\w+\(\s*t\s*,\s*\[([\s\S]*?)\]\s*\)/g

for (const { abs, rel } of source) {
const text = await readFile(abs, 'utf8')
Expand All @@ -183,6 +184,22 @@ for (const { abs, rel } of source) {
)
}
}

for (const listMatch of text.matchAll(KEY_LIST)) {
for (const litMatch of listMatch[1].matchAll(new RegExp(STRING, 'g'))) {
const key = litMatch[0].slice(1, -1)
if (!KEY_SHAPE.test(key)) continue

used.add(key)
if (allMessages[key] === undefined) {
fail(
`${rel} reads the message "${key}" through a key list passed to a translator ` +
'helper, and no English catalog carries it. A missing message renders as its ' +
'own key, in every language including English.',
)
}
}
}
}

const orphans = messageKeys.filter((key) => !used.has(key))
Expand Down
Loading