Repository navigation
fix(i18n): catch keys read through a copyFor() key list - #393
Merged
Merged
Conversation
Every theme's copy.ts batches its SlotCopy through a local copyFor(t, keys) helper that calls t.t(key) in a loop. Because the key reaches the translator through a variable, not a string literal, i18n-check's CALL regex never saw it, so a key listed there with no matching catalog entry passed silently — the exact shape of the "raw key leaks in the UI" report, even though every current copyFor() list in the repo does resolve. Scan the array literal passed to copyFor(t, [...]) directly and fail the same way the existing literal-call check does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every theme's copy.ts batches its SlotCopy through a local copyFor(t,
keys) helper that calls t.t(key) in a loop. Because the key reaches the
translator through a variable, not a string literal, i18n-check's CALL
regex never saw it, so a key listed there with no matching catalog entry
passed silently — the exact shape of the "raw key leaks in the UI" report,
even though every current copyFor() list in the repo does resolve.
Scan the array literal passed to copyFor(t, [...]) directly and fail the
same way the existing literal-call check does.